Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ramp): upgrade ramp-sdk to @2.0.4 #13318

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+8 −8
Open

chore(ramp): upgrade ramp-sdk to @2.0.4 #13318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
789a86f
feat: upgrades ramp sdk to 2.0.3
georgeweiler Feb 3, 2025
a24baa1
chore: fix yarn lock diff
georgeweiler Feb 3, 2025
9f9ede1
chore: fix package json diff
georgeweiler Feb 3, 2025
993f764
Merge branch 'main' of github.com:MetaMask/metamask-mobile into feat/…
georgeweiler Feb 4, 2025
e22098f
chore: upgrades sdk to 2.0.4
georgeweiler Feb 4, 2025
a1b66c5
Merge branch 'main' into feat/[email protected]
georgeweiler Feb 4, 2025
79f4b5d
Merge branch 'main' into feat/[email protected]
georgeweiler Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/UI/Ramp/Views/Quotes/Quotes.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ describe('Quotes', () => {
mockUseQuotesValues = {
...mockUseQuotesInitialValues,
isFetching: true,
data: null,
data: undefined,
};
render(Quotes);
expect(mockSetOptions).toBeCalledTimes(1);
Expand Down Expand Up @@ -200,7 +200,7 @@ describe('Quotes', () => {
mockUseQuotesValues = {
...mockUseQuotesInitialValues,
isFetching: true,
data: null,
data: undefined,
};
render(Quotes);
const fetchingQuotesText = screen.getByText('Fetching quotes');
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/Ramp/hooks/useQuotes.ts
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: could you take this opportunity to add a unit test for the hook?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it coming in a next PR, the hook will change a little bit so it is not worth it now, here it is: https://github.com/MetaMask/metamask-mobile/pull/13257/files#diff-66e86df8336a31e6a8432fb36644448548574f07052e57c265b4011145d0a423

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function useQuotes(amount: number | string) {
);

return {
data,
data: data?.quotes,
isFetching,
error,
query,
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
},
"dependencies": {
"@config-plugins/detox": "^8.0.0",
"@consensys/on-ramp-sdk": "1.28.8",
"@consensys/on-ramp-sdk": "^2.0.4",
"@keystonehq/bc-ur-registry-eth": "^0.19.1",
"@keystonehq/metamask-airgapped-keyring": "^0.13.1",
"@keystonehq/ur-decoder": "^0.12.2",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,10 +1429,10 @@
dependencies:
expo-build-properties "~0.12.1"

"@consensys/on-ramp-sdk@1.28.8":
version "1.28.8"
resolved "https://registry.yarnpkg.com/@consensys/on-ramp-sdk/-/on-ramp-sdk-1.28.8.tgz#e39d833974d9d49653a2ec107ffbebadb49580d1"
integrity sha512-snm1hGjIaFMHvB7seLoaBgUQXH1n8/iXPMSm96d5QItFKVw4GZyqsKRnuT2u/CwIeXtYOKf59q7+Lp0UMg+mFQ==
"@consensys/on-ramp-sdk@^2.0.4":
version "2.0.4"
resolved "https://registry.yarnpkg.com/@consensys/on-ramp-sdk/-/on-ramp-sdk-2.0.4.tgz#5068e1059510428bedff42e101bfc3a9060b1756"
integrity sha512-T8HsVlUe3hlC1c6umAT7nF4QG7oL7l0xgKTs7vob3bsVTNnnIo4uMsEYTbCI9El8gAnKiC9xHlXAZT9cXouFlA==
dependencies:
async "^3.2.3"
axios "^0.28.0"
Expand Down
Loading