Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding minimal LaTeX support #81

Merged
merged 2 commits into from
May 9, 2024

Conversation

volhovm
Copy link
Contributor

@volhovm volhovm commented Dec 4, 2023

Mdbook-linkcheck was giving a lot of false positives in our project due to extensive latex use. Since people in the parsing library cannot agree on "standardized way to write latex" I'm adding this simple customizable top-level fix for now by just cutting out LaTeX fragments before doing linkcheck.

@volhovm volhovm force-pushed the master branch 3 times, most recently from ab65a4f to 1e8686b Compare December 10, 2023 22:45
@volhovm volhovm marked this pull request as ready for review December 10, 2023 22:45
@volhovm
Copy link
Contributor Author

volhovm commented Dec 10, 2023

@Michael-F-Bryan This is now ready to review. It seems to work well on our mdbook (with like 30 files) so far, and as long as it's experimental and is not touching other parts of the code I hope it's fine that it's a bit hacky. It's a really nice feature :)

@blandger
Copy link

blandger commented Dec 11, 2023

An unit or integration test is needed.
E.g. I don't have any experience with latex and would like to see how it looks in MD text, how it's rendered in epub. Thanks.

@volhovm
Copy link
Contributor Author

volhovm commented Dec 14, 2023

@blandger Smoke tests added!

@volhovm volhovm marked this pull request as ready for review December 14, 2023 18:55
@volhovm
Copy link
Contributor Author

volhovm commented Jan 5, 2024

@blandger @Michael-F-Bryan Could you take a look at this one? I did add the tests so it should look good now.

@b-studios
Copy link

👍 something like this would be super useful. We are also getting a lot of false warnings that lead to error-blindness.

@volhovm
Copy link
Contributor Author

volhovm commented Feb 14, 2024

@blandger @Michael-F-Bryan Anything I can do to help speed this up? The PR should be ready+tested, so hopefully it's very fast to review.

@volhovm
Copy link
Contributor Author

volhovm commented Apr 17, 2024

@Michael-F-Bryan @blandger 👀 could you please take a look at this?

@blandger
Copy link

@volhovm sorry, I'm not an onwer or repo admin, the @Michael-F-Bryan is only.

Copy link
Owner

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry it's taken almost a year to get this reviewed. I was pretty burnt out towards the end of my time at Wasmer so a lot of my Open Source stuff was pushed to the back burner 😞

@Michael-F-Bryan Michael-F-Bryan merged commit e6f83ea into Michael-F-Bryan:master May 9, 2024
1 of 6 checks passed
@b-studios
Copy link

Don't worry, thanks for merging! :)

@volhovm
Copy link
Contributor Author

volhovm commented May 9, 2024

no worries, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants