-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding minimal LaTeX support #81
Conversation
ab65a4f
to
1e8686b
Compare
@Michael-F-Bryan This is now ready to review. It seems to work well on our mdbook (with like 30 files) so far, and as long as it's experimental and is not touching other parts of the code I hope it's fine that it's a bit hacky. It's a really nice feature :) |
An unit or integration test is needed. |
@blandger Smoke tests added! |
@blandger @Michael-F-Bryan Could you take a look at this one? I did add the tests so it should look good now. |
👍 something like this would be super useful. We are also getting a lot of false warnings that lead to error-blindness. |
@blandger @Michael-F-Bryan Anything I can do to help speed this up? The PR should be ready+tested, so hopefully it's very fast to review. |
@Michael-F-Bryan @blandger 👀 could you please take a look at this? |
@volhovm sorry, I'm not an onwer or repo admin, the @Michael-F-Bryan is only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry it's taken almost a year to get this reviewed. I was pretty burnt out towards the end of my time at Wasmer so a lot of my Open Source stuff was pushed to the back burner 😞
Don't worry, thanks for merging! :) |
no worries, thank you! |
Mdbook-linkcheck was giving a lot of false positives in our project due to extensive latex use. Since people in the parsing library cannot agree on "standardized way to write latex" I'm adding this simple customizable top-level fix for now by just cutting out LaTeX fragments before doing linkcheck.