feat: flex - added forbidden_same_day_booking_field_value notice
#1847
Conversation
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 5c3dab2 📊 Notices ComparisonNew Errors (1 out of 1575 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1575 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
Yay for acceptance tests! @tzujenchanmbd After taking a look at the new error, I think we missed an exception in the spec: report.json The report shows that
I think the fix here is to just remove Can you confirm before @cka-y updates the logic? |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 0c9b0f3 📊 Notices ComparisonNew Errors (1 out of 1588 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
Looks like this has been approved twice - just want to be explicit the logic change has to be made above to remove |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit f76c755 📊 Notices ComparisonNew Errors (1 out of 1588 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit b83dbea 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
it has now been addressed @emmambd |
Summary
This PR introduces a new validation rule that triggers an
ERRORseverity notice when the following conditions are met:booking_type = 1(Same-day booking)prior_notice_last_dayprior_notice_last_timeprior_notice_start_timeprior_notice_service_idExpected Behavior
A validation notice will be generated if the conditions listed above are met, flagging the presence of restricted fields in a same-day booking rule.
Example using this test dataset.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything