Add new ExtendedChoiceField and map ai_is_trustworthy "Yes"/"No" values to "CD"
#12976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2024
danielfmiranda
temporarily deployed
to
foundation-s-pni-field--2sibfr
danielfmiranda
commented
Oct 8, 2024
| @@ -15,8 +15,16 @@ def yes_no(value): | |||
|
|
|||
|
|
|||
| @register.filter | |||
| def extended_yes_no(value): | |||
| """Converts quad-state to human readable string""" | |||
| def extended_choice(value): | |||
There was a problem hiding this comment.
Updated this existing tag instead of creating a new one, because almost all of the GeneralProductPage's fields use the template "product_criterion_primary_info.html", which uses this tag, to render its selection.
danielfmiranda
temporarily deployed
to
foundation-s-pni-field--2sibfr
danielfmiranda
temporarily deployed
to
foundation-s-pni-field--2sibfr
danielfmiranda
force-pushed
the
pni-field-update-test-2
branch
from
2107efb
to
e580b50
Compare
danielfmiranda
temporarily deployed
to
foundation-s-pni-field--2sibfr
|
Closing in favor of: #12979 |
danielfmiranda
temporarily deployed
to
foundation-s-pni-trustw-eoreu3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
ExtendedChoiceFieldmodel, offering users the following selection of options:The
ai_is_untrustworthyfield in theGeneralProductPagemodel has been updated to use this new set of choices.Additionally, this PR includes a migration operation that iterates through all
GeneralProductPageinstances whereai_is_untrustworthyis currently set toYesorNo, and updates those values toCan’t Determine (CD)to align with the new choices.┆Issue is synchronized with this Jira Story