-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ExtendedChoiceField
and map ai_is_trustworthy
"Yes"/"No" values to "CD"
#12976
Closed
Closed
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3ab2d4a
added new ExtendedChoiceField to accommodate new list of choices
danielfmiranda 0f6554e
update ai_is_untrustworthy to use the new field type
danielfmiranda af17d61
migration operation to map yes/no to CD
danielfmiranda 79edbaf
updated tag and templates to account for new options
danielfmiranda c2b316d
formatting/linting
danielfmiranda b131d72
removed print statement from operation
danielfmiranda e580b50
Updated field label
danielfmiranda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
...i/networkapi/wagtailpages/migrations/0167_alter_generalproductpage_ai_is_untrustworthy.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Generated by Django 4.2.15 on 2024-10-07 21:41 | ||
|
||
from django.db import migrations | ||
|
||
import networkapi.wagtailpages.fields | ||
|
||
|
||
def map_yes_no_to_cant_determine(apps, schema_editor): | ||
GeneralProductPage = apps.get_model("wagtailpages", "GeneralProductPage") | ||
|
||
# Filter all instances where 'ai_is_untrustworthy' is 'Yes' or 'No' | ||
pages_to_update = GeneralProductPage.objects.filter(ai_is_untrustworthy__in=["Yes", "No"]) | ||
|
||
# Iterate over the pages and update them | ||
for page in pages_to_update: | ||
print( | ||
f"Product '{page.title}' with ID {page.id} has 'ai_is_untrustworthy' set as '{page.ai_is_untrustworthy}'. Updating to 'CD'." | ||
) | ||
page.ai_is_untrustworthy = "CD" | ||
page.save() | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("wagtailpages", "0166_homepagehighlights_replace_homepagenewsyoucanuse"), | ||
] | ||
|
||
operations = [ | ||
migrations.AlterField( | ||
model_name="generalproductpage", | ||
name="ai_is_untrustworthy", | ||
field=networkapi.wagtailpages.fields.ExtendedChoiceField(verbose_name="is this AI untrustworthy?"), | ||
), | ||
migrations.RunPython(map_yes_no_to_cant_determine), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this existing tag instead of creating a new one, because almost all of the GeneralProductPage's fields use the template "product_criterion_primary_info.html", which uses this tag, to render its selection.