Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package management] add implicit system package dependencies (dvx-197) #21204

Draft
wants to merge 5 commits into
base: mdgeorge/build-config-refactors
Choose a base branch
from

Conversation

mdgeorge4153
Copy link
Contributor

@mdgeorge4153 mdgeorge4153 commented Feb 13, 2025

Description

This PR enables you to use system packages (e.g. MoveStdlib, Sui, DeepBook) without explicitly adding them to your Move.toml. It works by querying the network during publication / upgrade for the protocol version and using that information to determine the correct version of the system dependencies. During build, the latest known version is used.

PR stack

#21204 Add implicit Sui dependencies
#21384 Refactors to BuildConfig
#21383 Add support for implicits to move package management

This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356

Test plan

Additional shell tests were added. Since these features are dependent on the protocol version of the network they are interacting with, some of these shell tests communicate with devnet, testnet, and mainnet (as well as localnet).

Some care was also taken to add explicit system dependencies to existing tests so that they would not start using this feature. I think in the future we should think more carefully about how we want to use implicit dependencies in tests.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 2:58pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 2:58pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 2:58pm

@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 13, 2025 15:17 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 changed the base branch from main to mdgeorge/framework-version-move February 13, 2025 15:18
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 15, 2025 12:17 — with GitHub Actions Inactive
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Feb 15, 2025
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 15, 2025 12:18 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 changed the base branch from mdgeorge/framework-version-move to main February 15, 2025 12:19
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 15, 2025 13:14 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Type: Documentation Improvements or additions to documentation label Feb 15, 2025
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 15, 2025 13:34 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 15, 2025 13:37 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 19, 2025 15:20 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 13:35 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/implicit-framework-dep-2 branch from 8ed1be0 to bc82eb6 Compare February 28, 2025 14:31
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 14:31 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/implicit-framework-dep-2 branch from bc82eb6 to 68e8874 Compare February 28, 2025 14:43
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 14:43 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/implicit-framework-dep-2 branch from 68e8874 to 274fb02 Compare February 28, 2025 14:55
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 14:55 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 14:55 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 changed the base branch from implicit-deps-on-move to mdgeorge/build-config-refactors February 28, 2025 15:16
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/implicit-framework-dep-2 branch from 274fb02 to a247208 Compare February 28, 2025 15:36
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/build-config-refactors branch from 33d730a to 6de7ccc Compare February 28, 2025 15:36
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 15:36 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 15:36 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants