-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Package management] add implicit system package dependencies (dvx-197) #21204
Draft
mdgeorge4153
wants to merge
5
commits into
mdgeorge/build-config-refactors
Choose a base branch
from
mdgeorge/implicit-framework-dep-2
base: mdgeorge/build-config-refactors
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Package management] add implicit system package dependencies (dvx-197) #21204
mdgeorge4153
wants to merge
5
commits into
mdgeorge/build-config-refactors
from
mdgeorge/implicit-framework-dep-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
amnn
reviewed
Feb 19, 2025
amnn
reviewed
Feb 19, 2025
external-crates/move/crates/move-package/src/resolution/dependency_graph.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-package/src/resolution/dependency_graph.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-package/src/resolution/dependency_graph.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-package/src/resolution/dependency_graph.rs
Outdated
Show resolved
Hide resolved
mdgeorge4153
commented
Feb 20, 2025
mdgeorge4153
commented
Feb 20, 2025
ebbc1fa
to
873cafe
Compare
8ed1be0
to
bc82eb6
Compare
873cafe
to
36d4c12
Compare
bc82eb6
to
68e8874
Compare
68e8874
to
274fb02
Compare
36d4c12
to
3405db6
Compare
…mplicit dependencies
…ch packages to keep for deps.
274fb02
to
a247208
Compare
33d730a
to
6de7ccc
Compare
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables you to use system packages (e.g.
MoveStdlib
,Sui
,DeepBook
) without explicitly adding them to yourMove.toml
. It works by querying the network during publication / upgrade for the protocol version and using that information to determine the correct version of the system dependencies. During build, the latest known version is used.PR stack
#21204 Add implicit Sui dependencies
#21384 Refactors to BuildConfig
#21383 Add support for implicits to move package management
This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356
Test plan
Additional shell tests were added. Since these features are dependent on the protocol version of the network they are interacting with, some of these shell tests communicate with devnet, testnet, and mainnet (as well as localnet).
Some care was also taken to add explicit system dependencies to existing tests so that they would not start using this feature. I think in the future we should think more carefully about how we want to use implicit dependencies in tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.