[package management] Add implicit dependency support to move compiler #21383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
force-pushed
the
implicit-deps-on-move
branch
from
ebbc1fa to
873cafe
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
force-pushed
the
implicit-deps-on-move
branch
from
873cafe to
36d4c12
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
force-pushed
the
implicit-deps-on-move
branch
from
36d4c12 to
3405db6
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This was referenced Feb 28, 2025
mdgeorge4153
requested review from
amnn,
tzakian,
stefan-mysten and
tnowacki
tzakian
reviewed
Feb 28, 2025
There was a problem hiding this comment.
Overall the changes look good to me. I think I'm fine with this as-is, but in the future we probably will want to revisit how explicit deps are handled w.r.t. implicit deps and have these behave more like package overrides today (or at least it's possibly something that we should discuss sometime).
| // implicits deps should be skipped if the manifest contains any of them | ||
| // explicitly (or if the manifest is for a system package). | ||
| let add_implicits: bool = !self.implicit_deps.iter().any(|(name, _)| { | ||
| root_manifest.dependencies.contains_key(name) || root_manifest.package.name == *name |
There was a problem hiding this comment.
Can we require the override = true be set here? May help us out in the future possibly (and also makes it clear that an override is happening here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for implicit dependencies on the move side.
PR stack
#21204 Add implicit Sui dependencies
#21384 Refactors to BuildConfig
#21383 Add support for implicits to move package management
This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356
Test plan
See
test_sources/implicits/README.mdfor a description of the new snapshot testsRelease notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.