Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TilesRendererBase: Add more "structure" for cached, per-engine fields #877

Open
gkjohnson opened this issue Dec 19, 2024 · 1 comment
Open
Milestone

Comments

@gkjohnson
Copy link
Contributor

gkjohnson commented Dec 19, 2024

Related to #422

  • Ie add a "cached" (or similarly named) object to tiles in the "Base" class implementation and existing slots for canonical objects, like "scene" or "content"
  • Sub classes like three.js can reliably set these fields so the base class can use them in function signatures - subclasses can otherwise set any other fields needed.
@gkjohnson
Copy link
Contributor Author

This change will also allow more events to be moved to the TilesRendererBase since the event content passes the "scene" to the event body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant