Make feature switch more efficient

NIAEFEUP · Nov 11, 2024 · 87189c7 · 87189c7
1 parent 911b2b1
commit 87189c7
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 30 deletions.
diff --git a/packages/uni_app/lib/view/settings/widgets/feature_flags/feature_flags_dialog.dart b/packages/uni_app/lib/view/settings/widgets/feature_flags/feature_flags_dialog.dart
@@ -4,36 +4,17 @@ import 'package:uni/controller/feature_flags/feature_flag_table.dart';
 import 'package:uni/generated/l10n.dart';
 import 'package:uni/view/settings/widgets/feature_flags/feature_switch_tile.dart';
 
-class FeatureFlagsDialog extends StatefulWidget {
+class FeatureFlagsDialog extends StatelessWidget {
   const FeatureFlagsDialog({super.key});
 
-  @override
-  FeatureFlagsDialogState createState() => FeatureFlagsDialogState();
-}
-
-class FeatureFlagsDialogState extends State<FeatureFlagsDialog> {
-  @override
-  void initState() {
-    super.initState();
-  }
-
-  void refresh() {
-    setState(() {});
-  }
-
   @override
   Widget build(BuildContext context) {
     return AlertDialog(
       title: Text(S.of(context).feature_flags),
       content: Column(
         mainAxisSize: MainAxisSize.min,
         children: FeatureFlagTable.getFeatureFlags()
-            .map(
-              (featureFlag) => FeatureSwitchTile(
-                featureFlag: featureFlag,
-                refreshDialog: refresh,
-              ),
-            )
+            .map((featureFlag) => FeatureSwitchTile(featureFlag: featureFlag))
             .toList(),
       ),
     );

diff --git a/packages/uni_app/lib/view/settings/widgets/feature_flags/feature_switch_tile.dart b/packages/uni_app/lib/view/settings/widgets/feature_flags/feature_switch_tile.dart
@@ -1,26 +1,35 @@
 import 'package:flutter/material.dart';
 import 'package:uni/model/feature_flags/generic_feature_flag.dart';
 
-class FeatureSwitchTile extends StatelessWidget {
+class FeatureSwitchTile extends StatefulWidget {
   const FeatureSwitchTile({
     required this.featureFlag,
-    required this.refreshDialog,
     super.key,
   });
 
   final GenericFeatureFlag featureFlag;
-  final void Function() refreshDialog;
+
+  @override
+  FeatureSwitchTileState createState() => FeatureSwitchTileState();
+}
+
+class FeatureSwitchTileState extends State<FeatureSwitchTile> {
+  void refresh() {
+    setState(() {});
+  }
+
+  Future<void> _onChanged(bool value) async {
+    await widget.featureFlag.setEnabled(enabled: value);
+    refresh();
+  }
 
   @override
   Widget build(BuildContext context) {
     return ListTile(
-      title: Text(featureFlag.getName(context)),
+      title: Text(widget.featureFlag.getName(context)),
       trailing: Switch.adaptive(
-        value: featureFlag.isEnabled(),
-        onChanged: (value) async {
-          await featureFlag.setEnabled(enabled: value);
-          refreshDialog();
-        },
+        value: widget.featureFlag.isEnabled(),
+        onChanged: _onChanged,
       ),
     );
   }