Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing day title translation #968

Merged
merged 16 commits into from
Jan 5, 2024
Merged

Fixing day title translation #968

merged 16 commits into from
Jan 5, 2024

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Sep 26, 2023

Closes #967

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana linked an issue Sep 26, 2023 that may be closed by this pull request
Fix: Translate Day Title #967
Closed
@DGoiana DGoiana mentioned this pull request Sep 26, 2023
Merged
7 tasks
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #968 (8c7d071) into develop (97a1246) will increase coverage by 1%.
Report is 2 commits behind head on develop.
The diff coverage is 24%.

Additional details and impacted files 
@@          Coverage Diff           @@
##           develop   #968   +/-   ##
======================================
+ Coverage       17%    17%   +1%     
======================================
  Files          206    207    +1     
  Lines         6381   6396   +15     
======================================
+ Hits          1039   1043    +4     
- Misses        5342   5353   +11

bdmendes
bdmendes requested changes Sep 28, 2023
View reviewed changes
uni/lib/l10n/intl_en.arb Outdated Show resolved Hide resolved
bdmendes
bdmendes previously approved these changes Oct 10, 2023
View reviewed changes
@bdmendes
Copy link
Member

@DGoiana can you rebase this?

@DGoiana DGoiana requested a review from bdmendes December 9, 2023 02:37
@bdmendes
Copy link
Member

@DGoiana take a look at this

@bdmendes
Copy link
Member

bdmendes commented Jan 5, 2024

Why is #1005 here?

@thePeras thePeras merged commit c61f222 into develop Jan 5, 2024
6 checks passed
@thePeras thePeras deleted the fix/translate-day-title branch January 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdmendes bdmendes bdmendes approved these changes

@thePeras thePeras thePeras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: Translate Day Title
5 participants
@DGoiana @bdmendes @thePeras @LuisDuarte1 @rubuy-74