Add more CI to GW-CI #1365
Open
Add more CI to GW-CI #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e024564.
This was referenced Nov 8, 2024
DavidNew-NOAA
requested review from
guillaumevernieres,
danholdaway,
RussTreadon-NOAA and
CoryMartin-NOAA
There was a problem hiding this comment.
Looks good @DavidNew-NOAA except for the missing gfsv17 test (c384/0.25). We don't want to run it a every pr's but it certainly needs to be checked regularly.
|
Question: do we expect reference checks to pass on all platforms? If not, on which platform(s) are the reference checks to be performed? |
|
@RussTreadon-NOAA I would expect them to pass within the tolerance that we set |
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/jcb-gdas
that referenced
this pull request
Nov 8, 2024
This PR is a companion to [#1365](NOAA-EMC/GDASApp#1365). It adds test reference blocks to the YAMLs for the JEDI-to-FV3 increment converters.
CoryMartin-NOAA
previously approved these changes
Nov 8, 2024
|
Reminder DO NOT MERGE this PR until GW PR #2992 is merged. |
danholdaway
reviewed
Nov 12, 2024
danholdaway
reviewed
Nov 12, 2024
danholdaway
reviewed
Nov 12, 2024
danholdaway
previously approved these changes
Nov 12, 2024
DavidNew-NOAA
dismissed stale reviews from danholdaway and CoryMartin-NOAA
via
1da115d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a companion to jcb-algorithms #7 and jcb-gdas #42. It does a couple things:
C96C48_hybatmDA,C96C48_ufs_hybatmDA,C96C48_hybatmaerosnowDA, andC48mx500_3DVarAOWCDA.C96C48_ufs_hybatmDA, so that we're actually testing the output, not just whether it cycles. This can be turned off in ``C96C48_ufs_hybatmDA.yaml``` if you just want.CMakeCache.txtfile and re-running make. This will allow us to use these tests in nightly testing.test/gw-ci/CMakeLists.txtis refactored quite a bit.The primary motivation for this PR is that we can run CI for our nightly testing of GDASApp. Also, anyone with a PR can easily do CI testing through CTests.
Note:
I'm not going to make a companion PR yet for the GW, because my branch will depend on #2992 being merged, but you can compare my branch to the branch for that PR here to see what it will do:
DavidNew-NOAA/global-workflow@feature/jcb-obsbias...DavidNew-NOAA:global-workflow:feature/gw-ci