Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more CI to GW-CI #7

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Add more CI to GW-CI #7

merged 4 commits into from
Nov 8, 2024

Conversation

DavidNew-NOAA
Copy link
Contributor

This PR is a companion to #1365. It makes inclusion of the testing blocks in the algorithm templates dependent on a do_testing parameter that will be set in the JCB base YAML.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@CoryMartin-NOAA CoryMartin-NOAA merged commit 7b074df into develop Nov 8, 2024
1 check failed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/gw-ci branch November 8, 2024 13:54
@danholdaway
Copy link
Collaborator

This is probably not an ideal way to change things. You need to have do_testing in every single application of JCB whether it's true or false. Better would have been:

{% if do_testing | default(false) %}

FYI the testing of jcb is working now so we shouldn't ignore failures. I suspect that if we tried to run GDASapp with this we'd see a lot of failures because of the need to add do_testing to all the jcb-base YAMLS.

@danholdaway
Copy link
Collaborator

Before I fix things, what was wrong with using {% if test_reference_filename is defined %}? We now have a mixture of this approach and do_testing across the YAMLs so we should pick one. I'm fine with do_testing if that's the way we want to go.

@DavidNew-NOAA
Copy link
Contributor Author

@danholdaway See my comment here NOAA-EMC/jcb-gdas#42 (comment)

@danholdaway
Copy link
Collaborator

OK. Then I will apply the same to all the YAMLs in jcb-algo.

@DavidNew-NOAA
Copy link
Contributor Author

This PR was merged a bit prematurely, I was hoping to have your eyes on it before that happened.

@danholdaway
Copy link
Collaborator

No problem. Straightforward fix I think. And apologies that I did not review sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants