Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds link for conventional comments #153

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

kellijohnson-NOAA
Copy link
Collaborator

What is the feature?

  • Add link to how to use conventional commit messages
  • As well as removes broken link to Review section.

How have you implemented the solution?

Does the PR impact any other area of the project, maybe another repo?

  • N/A

Close #107

Copy link
Contributor

@Bai-Li-NOAA Bai-Li-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to include those guides in the FIMS pr-checklist.yml as well?

@kellijohnson-NOAA
Copy link
Collaborator Author

Thanks for the suggestion @Bai-Li-NOAA. Do you think that we should just eliminate this section from the collaborative workflow guide and put the link in the GitHub action that you referenced above. By "this section", I mean the following
image

@Bai-Li-NOAA
Copy link
Contributor

@kellijohnson-NOAA, that sounds like a good plan to me. I also noticed that some links (e.g., Code Review link in the image) are not working. Maybe we can add a GHA (e.g., Linkspector) to check for broken links.

@kellijohnson-NOAA
Copy link
Collaborator Author

Okay, two new issues have been created one to have the links tested and one to create the link to conventional commits in FIMS. Finally, a force push with the relevant section removed is now the content of this PR. As soon as the tests pass I will merge it in.

@kellijohnson-NOAA kellijohnson-NOAA merged commit ca57af9 into main Sep 17, 2024
1 check passed
@kellijohnson-NOAA kellijohnson-NOAA deleted the provide-links branch September 17, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label comments and add a section to introduce the labels
2 participants