Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds link for conventional comments #153

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Adds link for conventional comments #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions 02-FIMS-Project-Overview.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,6 @@ assigned review team. The developer must resolve any issues arising from
the review and get confirmation from the review team before the pull
request is merged into the upstream branch.

### Reviewers

The reviewers are responsible for adhering to documented guidelines in
the [Code Review](#code-review) section. Reviewers should confirm that
the new code is able to build and run within their own development
environment as well as via the Github actions on the repository.
Reviewers should clearly document which components of the code need to
be improved to be accurate, comply with project guidelines and style, or
do not work, in the pull request thread so that the developer knows what
they need to fix.

### Project Lead

The Project Lead is responsible for driving decisions on FIMS features, user interfaces, and project guidelines and standards based on the vision and objectives of FIMS and discussions with the OST development team and regional product representatives. The project lead ensures the FIMS product satisfies user and business requirements, incorporates feedback, and iterates on the design and development as needed. The Project Lead will triage issues and pull requests weekly and ensure development and code review occur in a timely manner and according to project guidelines, priorities, and standards. The Project Lead is also responsible for communicating project status via maintenance of the [Github projects](https://github.com/orgs/NOAA-FIMS/projects) and scheduling tasks and managing change requests.
Expand Down
Loading