-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GSHP curves #1472
Update GSHP curves #1472
Conversation
…ightly > 2% off because of how you make the performance maps), but way closer than 50% off. Also actually added rated conditions rather than default to help with warnings
@jmaguire1 If this addresses the warning, you should be able to delete this line where we were exempting this warning. (The CI tests will throw an error for any warning that we don't exempt.) |
This is the current "base -> feature" scheme for ghp-related branches: master -> (1) fan/pump adjustment -> (2) ground_temperatures -> (3) geothermal loop -> (4) gshp curves From the above, these are ready for cursory review by @shorowit:
@joseph-robertson will pull "(3) geothermal loop" into a resstock branch. Should we do the same for (1) and (2)? Yes, we do. Then @prsh5175 can:
If we want to compare the new branch vs develop, and we're making TSV file changes, we'll need to either
To handle (a) here (preferred approach), we could probably introduce the new TSVs to develop, and they wouldn't actually do anything. Perhaps this can be something like a sensitivity/parametric analysis. |
@prsh5175 : Please reach out about TSV changes. I will have some guidance around how to make sure the tests pass and we get the comparisons to run. @joseph-robertson : For the comparisons approach "a) ensure samples are the same across the two branches" , we could base the PR off another branch (not develop) that has the TSV changes already in the branch. This way the comparisons would have the same samples. |
… still making sure this is the final set we want to run with but MUCH closer to our existing results.
…o-HPXML into gshp_curve_update
…o gshp_curve_update
Merge branch 'geothermal_loop' of https://github.com/NREL/OpenStudio-HPXML into gshp_curve_update
…HPXML into gshp_curve_update # Conflicts: # HPXMLtoOpenStudio/measure.xml # docs/source/workflow_inputs.rst
Impact of these changes on our GSHP annual energy consumption/COP predictions: <style> </style>
Overall impact across a few climate zones is that COP during heating slightly decreased (6%) and during cooling it slightly increased (-4%). However, the performance maps aren't strictly a bias in this fashion, it has more to do with where on the performance map we land: The heating performance map is closer to a biased result, I've spent a LONG time messing with how to generate the curves (using different rated conditions in the spreadsheet, looking at expanding the dataset a few different ways based on the approach in Tang's thesis). It's worth point out that the COP curves aren't direct inputs here: there's curves for heating capacity and power, which you can use to calculate COP given rated conditions. It's also worth pointing out that since the incoming water temperature depends on the deep ground temperature more than anything, we wouldn't expect to see that we're hitting the full range I'm plotting unless we went to some rather extreme climates. |
…o gshp_curve_update # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_sizing.csv # workflow/tests/base_results/results_workflow_simulations1.csv # workflow/tests/base_results/results_workflow_simulations1_bills.csv
One more thing I forgot to mention: it wasn't possible to easily get rid of the warnings around curves not being centered at the nominal point. We're closer than we were, but there's still several curves that are > 5% different than the nominal at rated conditions. Since there's no way to force the curve generation to set the 1.0 value at rated conditions, I can't easily remove those warnings as much as I'd like to. |
Pull Request Description
Since our curves are based on a product that's > 20 years old, seems like it's time for a refresh of the curves. I've been taking the spec sheet from the latest single speed product in the ClimateMaster product line: https://www.climatemaster.com/download/18.274be999165850ccd5b5b73/1535543867815/lc377-climatemaster-commercial-tranquility-20-single-stage-ts-series-water-source-heat-pump-submittal-set.pdf
And trying to use this data along with the EnergyPlus spreadsheet tools for generating appropriate curves that represent the performance of this product. The curves weren't able to be completely renormalized to 1.0 at rated conditions as the spreadsheet tool doesn't let users easily constrain the curves to this, although they are closer to 1.0 at rated conditions.
The overall impact here is a slight INCREASE in heating energy consumption (11% in Denver) and no substantial change in cooling (<1%, although in other climate zones it can be up to a 5% DECREASE in energy consumption), with some differences in impact depending on climate. It was pretty tricky to get the heating curves updated as the curve generation process is very sensitive to the rated conditions entered. The trick is to actually enter the conditions in the point with maximum heat output rather than what's truly a rated condition (which for water to air HP there's actually a few sets of rated conditions depending on the application).
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml
) has been updatedSample files have been added/updated (viatasks.rb
)Tests have been added/updated (e.g.,HPXMLtoOpenStudio/tests
and/orworkflow/tests/hpxml_translator_test.rb
)Documentation has been updatedopenstudio tasks.rb update_measures
has been run