Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust sizing for ducted MSHPs #1526

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Adjust sizing for ducted MSHPs #1526

merged 9 commits into from
Nov 7, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 25, 2023

Pull Request Description

Treat ducted MSHPs like ASHPs for equipment adjustments when autosized.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Oct 25, 2023
@shorowit shorowit self-assigned this Oct 25, 2023
@shorowit shorowit added this to the 1.7.0 milestone Oct 31, 2023
shorowit and others added 3 commits November 1, 2023 20:56
…o ducted_mshp_sizing

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/tests/test_hvac_sizing.rb
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
#	workflow/tests/base_results/results_sizing.csv
…o ducted_mshp_sizing

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results_bills.csv
#	workflow/tests/base_results/results_workflow_simulations1.csv
@shorowit shorowit marked this pull request as ready for review November 7, 2023 04:36
@shorowit shorowit merged commit 3e68033 into master Nov 7, 2023
@shorowit shorowit deleted the ducted_mshp_sizing branch November 7, 2023 05:26
@joseph-robertson joseph-robertson mentioned this pull request Nov 8, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant