Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust sizing for ducted MSHPs #1526

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Adjust sizing for ducted MSHPs #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
790b177
Treat ducted MSHPs like ASHPs for equipment adjustments in sizing.
shorowit Oct 25, 2023
2b7363b
Latest results.
Oct 25, 2023
db95285
Add airflow rates to CI artifact.
shorowit Oct 25, 2023
a890bb1
Merge branch 'ducted_mshp_sizing' of https://github.com/NREL/OpenStud…
shorowit Oct 25, 2023
8768fdd
Latest results.
Oct 25, 2023
91b20b6
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
shorowit Nov 2, 2023
08087e5
Latest results.
Nov 2, 2023
fae91e3
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
shorowit Nov 7, 2023
31b63e9
Latest results.
Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions HPXMLtoOpenStudio/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>b1e8aa00-533d-456a-874c-72241b4ced79</version_id>
<version_modified>2023-11-06T17:28:54Z</version_modified>
<version_id>02fbd449-a6df-4ef4-b0e1-7d3bccc19d0b</version_id>
<version_modified>2023-11-02T02:55:23Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -142,13 +142,13 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>AFA848DB</checksum>
<checksum>5BFBE071</checksum>
</file>
<file>
<filename>airflow.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>58EDCD0B</checksum>
<checksum>72035A85</checksum>
</file>
<file>
<filename>battery.rb</filename>
Expand All @@ -166,13 +166,7 @@
<filename>constructions.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>D28BD90F</checksum>
</file>
<file>
<filename>data/Xing_okstate_0664D_13659_Table_A-3.csv</filename>
<filetype>csv</filetype>
<usage_type>resource</usage_type>
<checksum>50B7055C</checksum>
<checksum>E7E0949D</checksum>
</file>
<file>
<filename>data/ashrae_622_wsf.csv</filename>
Expand Down Expand Up @@ -250,7 +244,7 @@
<filename>hotwater_appliances.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>668B8044</checksum>
<checksum>8C181D00</checksum>
</file>
<file>
<filename>hpxml.rb</filename>
Expand Down Expand Up @@ -280,7 +274,7 @@
<filename>hpxml_schematron/EPvalidator.xml</filename>
<filetype>xml</filetype>
<usage_type>resource</usage_type>
<checksum>6E861370</checksum>
<checksum>C2CB2C3F</checksum>
</file>
<file>
<filename>hpxml_schematron/iso-schematron.xsd</filename>
Expand All @@ -292,13 +286,13 @@
<filename>hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>DCDF2D3D</checksum>
<checksum>BD47E72B</checksum>
</file>
<file>
<filename>hvac_sizing.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>4D31E43D</checksum>
<checksum>1303DC8D</checksum>
</file>
<file>
<filename>lighting.rb</filename>
Expand All @@ -310,7 +304,7 @@
<filename>location.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>03FF5192</checksum>
<checksum>993E6E8F</checksum>
</file>
<file>
<filename>materials.rb</filename>
Expand All @@ -334,13 +328,13 @@
<filename>misc_loads.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>7D800940</checksum>
<checksum>AF5961B5</checksum>
</file>
<file>
<filename>output.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>3DE5829C</checksum>
<checksum>7AC7F779</checksum>
</file>
<file>
<filename>psychrometrics.rb</filename>
Expand Down Expand Up @@ -508,13 +502,13 @@
<filename>waterheater.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>73019632</checksum>
<checksum>C162FE36</checksum>
</file>
<file>
<filename>weather.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>A42A2AC9</checksum>
<checksum>40B06C92</checksum>
</file>
<file>
<filename>xmlhelper.rb</filename>
Expand All @@ -528,6 +522,12 @@
<usage_type>resource</usage_type>
<checksum>84D0E4E1</checksum>
</file>
<file>
<filename>in.schedules.csv</filename>
<filetype>csv</filetype>
<usage_type>test</usage_type>
<checksum>6244F711</checksum>
</file>
<file>
<filename>test_airflow.rb</filename>
<filetype>rb</filetype>
Expand All @@ -550,7 +550,7 @@
<filename>test_enclosure.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>833E46A5</checksum>
<checksum>8B84C7C1</checksum>
</file>
<file>
<filename>test_generator.rb</filename>
Expand All @@ -562,19 +562,19 @@
<filename>test_hotwater_appliance.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>F3ED25B6</checksum>
<checksum>9247176A</checksum>
</file>
<file>
<filename>test_hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>B02CDFFE</checksum>
<checksum>2DA48649</checksum>
</file>
<file>
<filename>test_hvac_sizing.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>0DF1F706</checksum>
<checksum>7784A366</checksum>
</file>
<file>
<filename>test_lighting.rb</filename>
Expand All @@ -586,7 +586,7 @@
<filename>test_location.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>663B10FB</checksum>
<checksum>46C13390</checksum>
</file>
<file>
<filename>test_miscloads.rb</filename>
Expand Down Expand Up @@ -628,7 +628,7 @@
<filename>test_weather.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>8CA4439B</checksum>
<checksum>84F8B616</checksum>
</file>
<file>
<filename>util.rb</filename>
Expand Down
19 changes: 13 additions & 6 deletions HPXMLtoOpenStudio/resources/hvac_sizing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,6 +1333,7 @@ def self.apply_hvac_equipment_adjustments(hvac_sizing_values, weather, hvac_heat

if not hvac_cooling.nil?
hvac_cooling_ap = hvac_cooling.additional_properties
is_ducted = !hvac_cooling.distribution_system.nil?
end

if hvac_sizing_values.Cool_Load_Tot <= 0
Expand All @@ -1342,7 +1343,12 @@ def self.apply_hvac_equipment_adjustments(hvac_sizing_values, weather, hvac_heat
hvac_sizing_values.Cool_Airflow = 0.0

elsif [HPXML::HVACTypeCentralAirConditioner,
HPXML::HVACTypeHeatPumpAirToAir].include? @cooling_type
HPXML::HVACTypeHeatPumpAirToAir].include?(@cooling_type) ||
([HPXML::HVACTypeMiniSplitAirConditioner,
HPXML::HVACTypeHeatPumpMiniSplit].include?(@cooling_type) && is_ducted)
# For central systems, the installer can take steps to try to meet both sensible and latent loads,
# such as different indoor/outdoor coil combinations and different blower settings.
# Ductless systems don't offer this flexibility.

entering_temp = @hpxml_bldg.header.manualj_cooling_design_temp
hvac_cooling_speed = get_sizing_speed(hvac_cooling_ap)
Expand Down Expand Up @@ -1446,12 +1452,12 @@ def self.apply_hvac_equipment_adjustments(hvac_sizing_values, weather, hvac_heat
# Calculate the final air flow rate using final sensible capacity at design
hvac_sizing_values.Cool_Airflow = calc_airflow_rate_manual_s(cool_load_sens_cap_design, (@cool_setpoint - @leaving_air_temp), hvac_sizing_values.Cool_Capacity)

elsif [HPXML::HVACTypeHeatPumpMiniSplit,
HPXML::HVACTypeMiniSplitAirConditioner,
HPXML::HVACTypeRoomAirConditioner,
elsif [HPXML::HVACTypeRoomAirConditioner,
HPXML::HVACTypePTAC,
HPXML::HVACTypeHeatPumpPTHP,
HPXML::HVACTypeHeatPumpRoom].include? @cooling_type
HPXML::HVACTypeHeatPumpRoom].include?(@cooling_type) ||
([HPXML::HVACTypeMiniSplitAirConditioner,
HPXML::HVACTypeHeatPumpMiniSplit].include?(@cooling_type) && !is_ducted)

hvac_cooling_speed = get_sizing_speed(hvac_cooling_ap)
hvac_cooling_shr = hvac_cooling_ap.cool_rated_shrs_gross[hvac_cooling_speed]
Expand Down Expand Up @@ -1554,6 +1560,7 @@ def self.apply_hvac_equipment_adjustments(hvac_sizing_values, weather, hvac_heat

if not hvac_heating.nil?
hvac_heating_ap = hvac_heating.additional_properties
is_ducted = !hvac_heating.distribution_system.nil?
end

if hvac_sizing_values.Heat_Load <= 0
Expand All @@ -1575,7 +1582,7 @@ def self.apply_hvac_equipment_adjustments(hvac_sizing_values, weather, hvac_heat
end

hvac_sizing_values.Heat_Capacity_Supp = hvac_sizing_values.Heat_Load_Supp
if @heating_type == HPXML::HVACTypeHeatPumpAirToAir
if (@heating_type == HPXML::HVACTypeHeatPumpAirToAir) || (@heating_type == HPXML::HVACTypeHeatPumpMiniSplit && is_ducted)
hvac_sizing_values.Heat_Airflow = calc_airflow_rate_manual_s(hvac_sizing_values.Heat_Capacity, (@supply_air_temp - @heat_setpoint), hvac_sizing_values.Heat_Capacity)
else
hvac_sizing_values.Heat_Airflow = calc_airflow_rate_user(hvac_sizing_values.Heat_Capacity, hvac_heating_ap.heat_rated_cfm_per_ton[-1], hvac_heating_ap.heat_capacity_ratios[-1])
Expand Down
19 changes: 19 additions & 0 deletions HPXMLtoOpenStudio/resources/output.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,23 @@ def self.get_total_hvac_capacities(hpxml_bldg)
end
return htg_cap, clg_cap, hp_backup_cap
end

def self.get_total_hvac_airflows(hpxml_bldg)
htg_cfm, clg_cfm = 0.0, 0.0
unit_multiplier = hpxml_bldg.building_construction.number_of_units
hpxml_bldg.hvac_systems.each do |hvac_system|
if hvac_system.is_a? HPXML::HeatingSystem
htg_cfm += hvac_system.heating_airflow_cfm.to_f * unit_multiplier
elsif hvac_system.is_a? HPXML::CoolingSystem
clg_cfm += hvac_system.cooling_airflow_cfm.to_f * unit_multiplier
if hvac_system.has_integrated_heating
htg_cfm += hvac_system.integrated_heating_system_airflow_cfm.to_f * unit_multiplier
end
elsif hvac_system.is_a? HPXML::HeatPump
htg_cfm += hvac_system.heating_airflow_cfm.to_f * unit_multiplier
clg_cfm += hvac_system.cooling_airflow_cfm.to_f * unit_multiplier
end
end
return htg_cfm, clg_cfm
end
end
5 changes: 4 additions & 1 deletion HPXMLtoOpenStudio/tests/test_hvac_sizing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,12 @@ def test_hvac_configurations
_autosized_model, _autosized_hpxml, autosized_bldg = _test_measure(args_hash)

htg_cap, clg_cap, hp_backup_cap = Outputs.get_total_hvac_capacities(autosized_bldg)
htg_cfm, clg_cfm = Outputs.get_total_hvac_airflows(autosized_bldg)
sizing_results[test_name] = { 'HVAC Capacity: Heating (Btu/h)' => htg_cap.round(1),
'HVAC Capacity: Cooling (Btu/h)' => clg_cap.round(1),
'HVAC Capacity: Heat Pump Backup (Btu/h)' => hp_backup_cap.round(1) }
'HVAC Capacity: Heat Pump Backup (Btu/h)' => hp_backup_cap.round(1),
'HVAC Airflow: Heating (cfm)' => htg_cfm.round(1),
'HVAC Airflow: Cooling (cfm)' => clg_cfm.round(1) }

next unless hpxml_bldg.heat_pumps.size == 1

Expand Down
Loading