Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply Curve Aggregation by Zone within GIDs #503

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

mjgleason
Copy link
Collaborator

@mjgleason mjgleason commented Jan 16, 2025

First cut at implementing supply curve aggregation for zones within GIDs. This functionality is enable by passing values to the new zones_dset argument.

I added new tests to tests/test_supply_curve_sc_aggregation.py, and the existing tests are all passing as well. I was unable to directly test that this functionality works with cap_cost_scale because the test gen/econ datasets do not have the correctly named economic datasets, but I did test that each zone + sc site is output to a separate sc_gid with the correct areas and capacities. Since the capital cost scale functionality is already tested separately, and runs downstream of the area and capacity calculations for each site in GenerationSupplyCurvePoint.summarize(), I don't this its okay not to test it.

This PR also includes some incidental changes to .pylintrc and .pre-commit-config.yaml to get them working again (they were pretty outdated).

@mjgleason mjgleason requested a review from ppinchuk January 16, 2025 20:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 95.74468% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.72%. Comparing base (68431d3) to head (a68e4f6).

Files with missing lines Patch % Lines
reV/supply_curve/aggregation.py 76.92% 3 Missing ⚠️
tests/test_supply_curve_sc_aggregation.py 96.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   87.57%   87.72%   +0.14%     
==========================================
  Files         122      122              
  Lines       18234    18380     +146     
==========================================
+ Hits        15969    16124     +155     
+ Misses       2265     2256       -9     
Flag Coverage Δ
unittests 87.72% <95.74%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving comments here now so that I don't forget them over the weekend

reV/supply_curve/aggregation.py Outdated Show resolved Hide resolved
reV/supply_curve/points.py Outdated Show resolved Hide resolved
reV/supply_curve/points.py Outdated Show resolved Hide resolved
reV/supply_curve/points.py Outdated Show resolved Hide resolved
reV/supply_curve/sc_aggregation.py Outdated Show resolved Hide resolved
@mjgleason mjgleason marked this pull request as ready for review January 21, 2025 18:28
ppinchuk

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants