Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes RN50 benchmark tests, move to DALI_EXTRA for RN50 DL FW iter tests #5824

Merged
merged 6 commits into from
Mar 3, 2025

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Feb 18, 2025

  • RN50 benchmark tests are redundant with TL1_decoder_perf, and
    don't have any threshold set so they can be removed
  • moves to DALI_EXTRA for RN50 RL FW iter test as it is about testing
    the iterators only, so any data source should d

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • RN50 benchmark tests are redundant with TL1_decoder_perf, and
    don't have any threshold set so they can be removed
  • moves to DALI_EXTRA for RN50 RL FW iter test as it is about testing
    the iterators only, so any data source should d

Additional information:

Affected modules and functionalities:

  • tests

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • dali/benchmark/dali_bench.h
    • dali/benchmark/resnet50_bench.py
    • dali/test/python/test_RN50_data_fw_iterators.py
    • qa/TL0_rn50-benchmarks/test.sh
    • qa/TL0_rn50_python-benchmarks/test.sh
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL JanuszL marked this pull request as draft February 18, 2025 12:22
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24129846]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24129846]: BUILD FAILED

…tests

- RN50 benchmark tests are redundant with TL1_decoder_perf, and
  don't have any threshold set so they can be removed
- moves to DALI_EXTRA for RN50 RL FW iter test as it is about testing
  the iterators only, so any data source should d

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24130535]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24130535]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24135993]: BUILD STARTED

#include "dali/core/common.h"
#include "dali/core/tensor_shape.h"
#include "dali/util/image.h"

namespace dali {

// Note: this is setup for the binary to be executed from "build"
const string image_folder = "/data/dali/benchmark/benchmark_images"; // NOLINT
const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it:

Suggested change
const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT
static const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24176234]: BUILD STARTED

@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 19, 2025

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24185193]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24185193]: BUILD FAILED

Signed-off-by: Janusz Lisiecki <[email protected]>
@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 19, 2025

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24186909]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24190861]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24195064]: BUILD STARTED

@JanuszL JanuszL marked this pull request as ready for review February 19, 2025 15:46
@mzient mzient self-assigned this Feb 19, 2025
@jantonguirao jantonguirao self-assigned this Feb 19, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24278032]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24278032]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24279115]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24591989]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24591853]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24592071]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24594636]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24594628]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24600111]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24600119]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24605763]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24606695]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24613653]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24600111]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24600119]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24606695]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24613653]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24606695]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24613653]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24704933]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24705858]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24710967]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24710967]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24710967]: BUILD PASSED

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24782775]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24782775]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24782775]: BUILD PASSED

@JanuszL JanuszL merged commit 32153ea into NVIDIA:main Mar 3, 2025
6 checks passed
@JanuszL JanuszL deleted the dali_bench branch March 3, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants