-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes RN50 benchmark tests, move to DALI_EXTRA for RN50 DL FW iter tests #5824
Conversation
CI MESSAGE: [24129846]: BUILD STARTED |
CI MESSAGE: [24129846]: BUILD FAILED |
…tests - RN50 benchmark tests are redundant with TL1_decoder_perf, and don't have any threshold set so they can be removed - moves to DALI_EXTRA for RN50 RL FW iter test as it is about testing the iterators only, so any data source should d Signed-off-by: Janusz Lisiecki <[email protected]>
CI MESSAGE: [24130535]: BUILD STARTED |
CI MESSAGE: [24130535]: BUILD FAILED |
CI MESSAGE: [24135993]: BUILD STARTED |
dali/benchmark/dali_bench.h
Outdated
#include "dali/core/common.h" | ||
#include "dali/core/tensor_shape.h" | ||
#include "dali/util/image.h" | ||
|
||
namespace dali { | ||
|
||
// Note: this is setup for the binary to be executed from "build" | ||
const string image_folder = "/data/dali/benchmark/benchmark_images"; // NOLINT | ||
const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it:
const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT | |
static const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Janusz Lisiecki <[email protected]>
CI MESSAGE: [24176234]: BUILD STARTED |
!build |
CI MESSAGE: [24185193]: BUILD STARTED |
CI MESSAGE: [24185193]: BUILD FAILED |
Signed-off-by: Janusz Lisiecki <[email protected]>
!build |
CI MESSAGE: [24186909]: BUILD STARTED |
CI MESSAGE: [24190861]: BUILD STARTED |
CI MESSAGE: [24195064]: BUILD STARTED |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
CI MESSAGE: [24278032]: BUILD STARTED |
CI MESSAGE: [24278032]: BUILD FAILED |
CI MESSAGE: [24279115]: BUILD STARTED |
CI MESSAGE: [24591989]: BUILD STARTED |
CI MESSAGE: [24591853]: BUILD FAILED |
CI MESSAGE: [24592071]: BUILD STARTED |
CI MESSAGE: [24594636]: BUILD STARTED |
CI MESSAGE: [24594628]: BUILD STARTED |
CI MESSAGE: [24600111]: BUILD STARTED |
CI MESSAGE: [24600119]: BUILD STARTED |
CI MESSAGE: [24605763]: BUILD STARTED |
CI MESSAGE: [24606695]: BUILD STARTED |
CI MESSAGE: [24613653]: BUILD STARTED |
CI MESSAGE: [24600111]: BUILD FAILED |
CI MESSAGE: [24600119]: BUILD FAILED |
CI MESSAGE: [24606695]: BUILD FAILED |
CI MESSAGE: [24613653]: BUILD FAILED |
CI MESSAGE: [24606695]: BUILD PASSED |
CI MESSAGE: [24613653]: BUILD PASSED |
CI MESSAGE: [24704933]: BUILD STARTED |
CI MESSAGE: [24705858]: BUILD STARTED |
CI MESSAGE: [24710967]: BUILD STARTED |
CI MESSAGE: [24710967]: BUILD FAILED |
CI MESSAGE: [24710967]: BUILD PASSED |
Signed-off-by: Janusz Lisiecki <[email protected]>
CI MESSAGE: [24782775]: BUILD STARTED |
CI MESSAGE: [24782775]: BUILD FAILED |
CI MESSAGE: [24782775]: BUILD PASSED |
don't have any threshold set so they can be removed
the iterators only, so any data source should d
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
don't have any threshold set so they can be removed
the iterators only, so any data source should d
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A