Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes RN50 benchmark tests, move to DALI_EXTRA for RN50 DL FW iter tests #5824

Merged
merged 6 commits into from
Mar 3, 2025
Merged

Removes RN50 benchmark tests, move to DALI_EXTRA for RN50 DL FW iter tests #5824

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bcb7787
Removes RN50 benchmark tests, move to DALI_EXTRA for RN50 DL FW iter …
JanuszL Feb 18, 2025
bbd5565
Review fix
JanuszL Feb 18, 2025
6b8012a
Fix
JanuszL Feb 19, 2025
56086e5
More fixes
JanuszL Feb 20, 2025
c83c5c8
Fixes
JanuszL Feb 24, 2025
08e0d86
More fixes
JanuszL Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dali/benchmark/dali_bench.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,15 @@
#include <string>
#include <vector>

#include "dali/test/dali_test_config.h"
#include "dali/core/common.h"
#include "dali/core/tensor_shape.h"
#include "dali/util/image.h"

namespace dali {

// Note: this is setup for the binary to be executed from "build"
const string image_folder = "/data/dali/benchmark/benchmark_images"; // NOLINT
const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it:

Suggested change
const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT
static const string image_folder = testing::dali_extra_path() + "db/single/jpeg"; // NOLINT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


class DALIBenchmark : public benchmark::Fixture {
public:
Expand Down
153 changes: 0 additions & 153 deletions dali/benchmark/resnet50_bench.py
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion dali/test/python/test_RN50_data_fw_iterators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
import nvidia.dali.types as types
import argparse
import time
from test_utils import get_dali_extra_path
import os

data_paths = ["/data/imagenet/train-jpeg"]
data_paths = os.path.join(get_dali_extra_path(), "db", "single", "jpeg")


class RN50Pipeline(Pipeline):
Expand Down
26 changes: 0 additions & 26 deletions qa/TL0_rn50-benchmarks/test.sh
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions qa/TL0_rn50_python-benchmarks/test.sh
View file
Open in desktop

This file was deleted.

Loading