-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on env vars #11991
base: main
Are you sure you want to change the base?
Add docs on env vars #11991
Conversation
Signed-off-by: Sangkug Lym <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: erhoo82 <[email protected]>
@pablo-garay @ko3n1g can we force-merge? This is a docs change and force-merge would it get it off the CI queue. |
It also changes Python code by removing env vars |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11991 +/- ##
==========================================
+ Coverage 30.30% 30.42% +0.12%
==========================================
Files 1387 1395 +8
Lines 176283 177027 +744
Branches 27091 27142 +51
==========================================
+ Hits 53423 53866 +443
- Misses 118776 119072 +296
- Partials 4084 4089 +5 ☔ View full report in Codecov by Sentry. |
"NVTE_DP_AMAX_REDUCE_INTERVAL": "0", | ||
"NVTE_ASYNC_AMAX_REDUCTION": "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n00b question: why can we drop setting these now?
What does this PR do ?
Add doc strings to env vars
Remove deprecated env var
Changelog
Usage
n/a
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information