upgrade jucx to 1.18 #12058
Merged
upgrade jucx to 1.18 #12058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Puller <[email protected]>
Signed-off-by: Zach Puller <[email protected]>
abellina
reviewed
Feb 3, 2025
docs/additional-functionality/shuffle-docker-examples/Dockerfile.ubuntu_rdma
Outdated
Show resolved
Hide resolved
Signed-off-by: Zach Puller <[email protected]>
abellina
approved these changes
Feb 10, 2025
|
build |
abellina
requested changes
Feb 10, 2025
Signed-off-by: Zach Puller <[email protected]>
abellina
approved these changes
Feb 10, 2025
|
build |
| @@ -16,15 +16,15 @@ | |||
| # Sample Dockerfile to install UCX in a Rocky Linux 8 image. | |||
| # | |||
| # The parameters are: | |||
| # - CUDA_VER: 11.8.0 by default | |||
| # - CUDA_VER: 12.8.0 by default | |||
There was a problem hiding this comment.
PR description does not cover this change, is it needed?
|
LGTM, +1 |
NvTimLiu
approved these changes
Feb 11, 2025
|
The original issue seems targeting for 25.04. Should we retarget this PR to branch-25.04? |
No we decided to explicitly get this one into 25.02, but good question |
zpuller
added a commit
that referenced
this pull request
Feb 12, 2025
<!-- Thank you for contributing to RAPIDS Accelerator for Apache Spark! Here are some guidelines to help the review process go smoothly. 1. Please write a description in this text box of the changes that are being made. 2. Please ensure that you have written units tests for the changes made/features added. 3. If you are closing an issue please use one of the automatic closing words as noted here: https://help.github.com/articles/closing-issues-using-keywords/ 4. If your pull request is not ready for review but you want to make use of the continuous integration testing facilities please label it with `[WIP]`. 5. If your pull request is ready to be reviewed without requiring additional work on top of it, then remove the `[WIP]` label (if present). 6. Once all work has been done and review has taken place please do not add features or make changes out of the scope of those requested by the reviewer (doing this just add delays as already reviewed code ends up having to be re-reviewed/it is hard to tell what is new etc!). Further, please avoid rebasing your branch during the review process, as this causes the context of any comments made by reviewers to be lost. If conflicts occur during review then they should be resolved by merging into the branch used for making the pull request. Many thanks in advance for your cooperation! --> Reverts #12058 The above PR was found to break `ucx_perftest` with `-m cuda` in the ubuntu rdma container in a CI test. This is caused specifically by the CUDA version upgrade in the PR. --------- Signed-off-by: Zach Puller <[email protected]>
zpuller
added a commit
that referenced
this pull request
Feb 12, 2025
<!-- Thank you for contributing to RAPIDS Accelerator for Apache Spark! Here are some guidelines to help the review process go smoothly. 1. Please write a description in this text box of the changes that are being made. 2. Please ensure that you have written units tests for the changes made/features added. 3. If you are closing an issue please use one of the automatic closing words as noted here: https://help.github.com/articles/closing-issues-using-keywords/ 4. If your pull request is not ready for review but you want to make use of the continuous integration testing facilities please label it with `[WIP]`. 5. If your pull request is ready to be reviewed without requiring additional work on top of it, then remove the `[WIP]` label (if present). 6. Once all work has been done and review has taken place please do not add features or make changes out of the scope of those requested by the reviewer (doing this just add delays as already reviewed code ends up having to be re-reviewed/it is hard to tell what is new etc!). Further, please avoid rebasing your branch during the review process, as this causes the context of any comments made by reviewers to be lost. If conflicts occur during review then they should be resolved by merging into the branch used for making the pull request. Many thanks in advance for your cooperation! --> Reverts #12058 The above PR was found to break ucx_perftest with -m cuda in the ubuntu rdma container in a CI test. This is caused specifically by the CUDA version upgrade in the PR. --------- Signed-off-by: Zach Puller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11985
Upgrades jucx libs from 1.16 to 1.18.
Also upgrades shuffle example dockerfiles to 12.8 CUDA images, which support fabric memory handles and have support for grace-blackwell, which will be supported in UCX 1.18.1
Based off of #11147
Tested building docker images for ubuntu and rocky, running
ucx_perftestin container, and running test queries with ucx shuffle enabled (on test clusters).