Fix the issue of ExtraPlugins loading multiple times #12077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <[email protected]>
gerashegalov
reviewed
Feb 7, 2025
| @@ -353,7 +353,7 @@ object RapidsPluginUtils extends Logging { | |||
| val resourceName = "spark-rapids-extra-plugins" | |||
| val classLoader = RapidsPluginUtils.getClass.getClassLoader | |||
| val resourceUrls = classLoader.getResources(resourceName) | |||
| val resourceUrlArray = resourceUrls.asScala.toArray | |||
| val resourceUrlArray = resourceUrls.asScala.toArray.distinct | |||
There was a problem hiding this comment.
Please add a warning listing duplicates.
This looks like a deployment error to me when there are multiple identical entries on the classpath that the user might want to fix.
There was a problem hiding this comment.
Yes, I added the warning clause.
|
build |
sperlingxx
changed the title
res-life
approved these changes
Feb 8, 2025
gerashegalov
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12076
The PR is about to fix the multiple loading problem which is due to the duplicated URL paths for single extra plugin.