Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of ExtraPlugins loading multiple times #12077

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Fix the issue of ExtraPlugins loading multiple times #12077

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96758bc
add an explicit distinct to dedup
sperlingxx Feb 7, 2025
d2084dc
update
sperlingxx Feb 7, 2025
aa2bd84
fix
sperlingxx Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql-plugin/src/main/scala/com/nvidia/spark/rapids/Plugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ object RapidsPluginUtils extends Logging {
val resourceName = "spark-rapids-extra-plugins"
val classLoader = RapidsPluginUtils.getClass.getClassLoader
val resourceUrls = classLoader.getResources(resourceName)
val resourceUrlArray = resourceUrls.asScala.toArray
val resourceUrlArray = resourceUrls.asScala.toArray.distinct
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a warning listing duplicates.

This looks like a deployment error to me when there are multiple identical entries on the classpath that the user might want to fix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I added the warning clause.


if (resourceUrlArray.isEmpty) {
logDebug(s"Could not find file $resourceName in the classpath, not loading extra plugins")
Expand Down