PR validation, tool config #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standardise format, change name of tests file
new workflow to check commit format and code style against pre-commit config
update pre-commit repo versions and switch black to ruff
version specifier is deprecated
should be unnecessary to specify python 3 now
not pinning sqlalchemy and requests because they're used elsewhere and pinning will probably cause some kind of horrible conflict; everything else has just been pinned to major versions, except spacy which needs to be <3.8 for python 3.8 compatibility (so is just pinned to the latest possible minor version)
F401 returns linting errors as well as auto-fixes, so this disables the errors and just applies the fixes
auto reformat with ruff/docformatter/prettier after config changes
alycejenni
force-pushed
the
ginger/standardise
branch
from
7638bb2
to
1dd01dd
Compare
Pull Request Test Coverage Report for Build #150Details
💛 - Coveralls |
apparently they don't get pulled from pyproject.toml when using the github action
as recommended by docformatter issue 172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch extension update to add PR validation workflow, standardise/update existing workflows, switch to Ruff, and remove the version specifier from docker-compose.yml.
This also revealed some issues with dependencies (particularly spacy) in this extension, so this PR also pins dependency versions and makes CLI packages optional.