Updates for NMLv2.3 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temp disable sbml validation
fix(mac): check for `libnrnmech.dylib` on macs
…channel Add test on nrn unit conversions
Feat/99 treat all normal - test in experimental branch
@sanjayankur31 as all the other org.neuroml.x libs have the same version num, it's best to update all at once or just before release to ensure they are compatible. jNeuroML is easier to update and can be incremented when this change for all is fully tested.
... that *always* includes all segments.
This improves the generated graph when using other layouts Reference: https://graphviz.org/docs/attrs/overlap/
Feat/99 treat all normal - test on experimental
jsonserializer: Treat `all` as a normal subgroup, reserve and use `nrn_all` as list of all segments/sections
feat(graphviz): prevent overlapping in generated graphs
... setting values for the cvode params enables it
More general tidying generated mod files
Allows length and diameter when parameters in lems abstract cell to be used for section in hoc
feat(neuron-writer): use `Meta` to allow use of cvode
Update to use of units in mod files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.