Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for NMLv2.3 #96

Merged
merged 92 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
f69e4f5
workaround for problematic cnexp numerics
borismarin Apr 4, 2016
d8152a8
using preexistent logic for checking Ca dependency
borismarin Apr 4, 2016
fc9c64e
explicit args for rates method; refactored Ca logic
borismarin Apr 11, 2016
e453b6d
rearranging mod derivative blocks to please nrnoc parser
borismarin Apr 12, 2016
da65cfb
Merge remote-tracking branch 'origin/development' into integrationMethod
borismarin Apr 12, 2016
c28816d
rearranging mod derivative blocks to please nrnoc parser
borismarin Apr 12, 2016
4687b26
Merge branch 'development' into integrationMethod
borismarin Aug 29, 2017
6ec9537
Merge branch 'development' into integrationMethod
borismarin Aug 30, 2017
66e62ef
Add ci
pgleeson Nov 10, 2021
4b32cd8
Initial EDEN writer
pgleeson Apr 26, 2022
46a2f98
EDEN export fix
pgleeson Apr 26, 2022
9be0c7c
To v1.9.0 for NeuroML v2.3
pgleeson May 12, 2022
16fc383
Another option for finding compiled mod files
pgleeson Jun 10, 2022
b01a1d1
Increase chancks on locations for generated neuron libraries
pgleeson Jun 14, 2022
7b0de63
Update options for export of json from netpyne
pgleeson Jun 29, 2022
c79c654
Update netpyne export
pgleeson Jun 29, 2022
19d35ea
Update README.md
pgleeson Aug 1, 2022
a38d19e
Temp disable sbml validation
pgleeson Aug 1, 2022
a80d3ee
Merge pull request #83 from NeuroML/test_sbml_fix
pgleeson Aug 2, 2022
4fb1529
Put back in test on sbml validity
pgleeson Aug 2, 2022
d9c0814
Merge branch 'development' into experimental
pgleeson Aug 8, 2022
2def42c
Mainly whitespace changes from atom
pgleeson Aug 15, 2022
b456111
Merge branch 'development' into experimental
pgleeson Oct 13, 2022
c30c411
fix(mac): check for `libnrnmech.dylib` on macs
sanjayankur31 Oct 14, 2022
0f4f8e2
Merge pull request #86 from NeuroML/fix/issue-85
pgleeson Oct 19, 2022
2282e60
Merge branch 'development' into test_sbml_fix
pgleeson Oct 19, 2022
457b51c
Bwetter handling of np exec
pgleeson Nov 2, 2022
e1065f4
Use getMembraneProperties(cell) & formatting
pgleeson Nov 2, 2022
2514f4b
Improved netpyne json handling
pgleeson Nov 2, 2022
4e2a53c
Add variable to mod file to record current dens specific to that ion …
pgleeson Nov 8, 2022
3f7319b
More tests on units
pgleeson Nov 9, 2022
e889671
Merge branch 'development' into experimental
pgleeson Nov 9, 2022
cec7dba
Correcting units for Neuron saving of channel cond/current
pgleeson Nov 10, 2022
014e4b5
chore(process-manager): add new NEURON release versions
sanjayankur31 Nov 22, 2022
8bdd78e
feat(process-manager): check PATH folders for NEURON executables also
sanjayankur31 Nov 22, 2022
04bcb29
Support __SIMULATOR__ & __TIMESTAMP__ in report files for nrn/npyne
pgleeson Nov 22, 2022
e9c0cf9
Merge branch 'experimental' into feat/check-PATH
pgleeson Nov 22, 2022
e91b8f3
Tweak of path finding
pgleeson Nov 22, 2022
05e3590
Merge branch 'development' into test_sbml_fix
pgleeson Nov 22, 2022
71f6c27
Merge pull request #88 from NeuroML/test_sbml_fix
pgleeson Nov 22, 2022
dfc59ac
Merge branch 'feat/check-PATH' into experimental
pgleeson Nov 23, 2022
4d0d5f6
Merge pull request #89 from NeuroML/experimental
pgleeson Nov 23, 2022
03825a1
Improved handling nrn simulations with spaces
pgleeson Dec 6, 2022
c3856cc
Tweaking output text
pgleeson Dec 6, 2022
8ab4a64
fix(check-PATH): split using colon, not semi-colon
sanjayankur31 Dec 8, 2022
b24e8a7
Merge pull request #90 from NeuroML/fix/path-colon-not-semi
sanjayankur31 Dec 8, 2022
fadabdc
Update README.md
pgleeson Feb 8, 2023
55ce746
Test on java 19
Feb 23, 2023
66b8f35
Windows ci fix
Feb 23, 2023
2ed81b6
Merge pull request #91 from NeuroML/experimental
pgleeson Feb 23, 2023
68020e7
Add support for arm64 on mac with apple silicon
Feb 23, 2023
3a742e8
Merge branch 'integrationMethod' into development
borismarin Apr 1, 2023
0fcea86
Revert num integration method changes
pgleeson Apr 4, 2023
4c62296
feat: remove `getSegment` from `SpecificCapacitance` and `Resistivity`
sanjayankur31 May 3, 2023
0b53f1a
Merge branch 'master' into development
pgleeson May 3, 2023
ce811a6
Test on win 2019
pgleeson May 3, 2023
f06efcb
More windows-2019
pgleeson May 3, 2023
0d98619
Merge pull request #94 from NeuroML/feat/remove-get-segment
pgleeson May 3, 2023
cac1129
Merge pull request #95 from NeuroML/experimental
pgleeson May 3, 2023
179d6dd
Merge branch 'master' into experimental
pgleeson May 4, 2023
766d52d
Merge branch 'experimental' into development
pgleeson May 4, 2023
527c1f7
feat(json-serializer): do not treat `all` as a special segment group
sanjayankur31 May 19, 2023
8a36b63
chore: bump patch version to indicate bugfix
sanjayankur31 May 19, 2023
b5bf3d6
Merge pull request #101 from NeuroML/feat/99-treat-all-normal
pgleeson May 26, 2023
2a3a548
Reverting to v1.9.0
pgleeson May 26, 2023
bd6dbe2
feat(neuron-writer): reserve `all` as a sectionlist/segment group
sanjayankur31 May 30, 2023
4613f18
Merge remote-tracking branch 'origin/experimental' into feat/99-treat…
sanjayankur31 May 30, 2023
2c38699
feat(json-serializer): do not include duplicate segments/sections in …
sanjayankur31 May 30, 2023
a4b0a2b
feat(graphviz): prevent overlapping in generated graphs
sanjayankur31 Jun 8, 2023
a78098e
chore(graphviz): remove extra new line
sanjayankur31 Jun 8, 2023
44f1dd5
Merge pull request #104 from NeuroML/feat/99-treat-all-normal
pgleeson Aug 7, 2023
23224d7
Merge pull request #100 from NeuroML/feat/99-treat-all-normal
pgleeson Aug 7, 2023
e24fe1b
Merge branch 'feat/graphviz-no-overlap' into experimental
pgleeson Aug 8, 2023
910c33d
Merge pull request #102 from NeuroML/feat/graphviz-no-overlap
pgleeson Aug 8, 2023
bac9079
Merge branch 'development' into experimental
pgleeson Aug 8, 2023
7956eee
Small tweaks to sedml/sbml writers
pgleeson Aug 23, 2023
a62e2bf
feat(neuron-writer): use `Meta` to allow use of cvode
sanjayankur31 Aug 23, 2023
98dd808
fix(neuron-writer): set default `dt` even when cvode is in use
sanjayankur31 Aug 23, 2023
5e52dae
feat(neuron-writer): include both cvode and standard integration
sanjayankur31 Aug 24, 2023
fd5f50e
fix(neuron-writer): don't resize recorder vector when using cvode
sanjayankur31 Aug 25, 2023
b676a16
fix(neuron-writer): do not resize recording vector when using cvode
sanjayankur31 Aug 25, 2023
291292a
Update formatting of generated neuron code
pgleeson Aug 29, 2023
c5bfff3
Update Neuron units for capacitance (nF) & ensure dv/dt is units mV/ms
pgleeson Sep 5, 2023
47935a5
Update pynn cell export
pgleeson Sep 5, 2023
b4ff16c
Update versions for github actions
pgleeson Sep 5, 2023
c01455f
Further updates to neuron units - tested across more models
pgleeson Sep 6, 2023
3eb7762
Uopdate neuron units for idealGasConstantDims
pgleeson Sep 8, 2023
0e27fff
Merge pull request #105 from NeuroML/feat/nrn-cvode
pgleeson Sep 8, 2023
ac1b521
Merge pull request #107 from NeuroML/experimental
pgleeson Sep 12, 2023
b86a860
Add distribution: 'temurin'
pgleeson Sep 12, 2023
9191bb1
To v1.9.1
pgleeson Sep 20, 2023
f7ec707
Merge pull request #108 from NeuroML/experimental
pgleeson Sep 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ name: Java CI with Maven

on:
push:
branches: [ master, development, experimental, osb* ]
branches: [ master, development, experimental, osb*, test* ]
pull_request:
branches: [ master, development, experimental, osb* ]
branches: [ master, development, experimental, osb*, test* ]

jobs:
build_and_test:
Expand All @@ -16,14 +16,14 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ '8', '11', '16', '17']
runs-on: [ubuntu-latest, macos-11, windows-2019 ]
java: [ '8', '11', '16', '17', '19']
runs-on: [ubuntu-latest, macos-latest, windows-2019 ]

name: Test on Java ${{ matrix.Java }} on ${{ matrix.runs-on }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up JDK ${{ matrix.Java }}
uses: actions/setup-java@v2
uses: actions/setup-java@v3
with:
java-version: ${{ matrix.Java }}
distribution: 'temurin'
Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,18 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: nelonoel/[email protected]

- name: Set up JDK 11
uses: actions/setup-java@v1
uses: actions/setup-java@v3
with:
java-version: 11
distribution: 'temurin'
java-package: jdk

- name: Set up Python 3.9
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.9

Expand All @@ -33,29 +34,29 @@ jobs:
pip install ghp-import

- name: Checkout NeuroML2
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: NeuroML/NeuroML2
ref: development
path: NeuroML2

- name: Checkout org.lemsml
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: LEMS/jLEMS
ref: development
path: jLEMS


- name: Checkout org.neuroml.model.injectingplugin
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: NeuroML/org.neuroml.model.injectingplugin
ref: development
path: org.neuroml.model.injectingplugin

- name: Checkout org.neuroml.model
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: NeuroML/org.neuroml.model
ref: development
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,6 @@ src/test/resources/examples/*nrn.py
/Test.gv
/Test.png
/src/test/resources/examples/report*.txt
/.classpath
/.project
/.settings
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
Export from NeuroML & LEMS
==========================

[![Java CI with Maven](https://github.com/NeuroML/org.neuroml.export/actions/workflows/ci.yml/badge.svg)](https://github.com/NeuroML/org.neuroml.export/actions/workflows/ci.yml)
[![Java CI with Maven](https://github.com/NeuroML/org.neuroml.export/actions/workflows/ci.yml/badge.svg)](https://github.com/NeuroML/org.neuroml.export/actions/workflows/ci.yml) [![Publish Javadocs](https://github.com/NeuroML/org.neuroml.export/actions/workflows/docs.yml/badge.svg)](https://github.com/NeuroML/org.neuroml.export/actions/workflows/docs.yml)

[![GitHub](https://img.shields.io/github/license/NeuroML/org.neuroml.export)](https://github.com/NeuroML/org.neuroml.export/blob/master/LICENSE.lesser)
[![GitHub pull requests](https://img.shields.io/github/issues-pr/NeuroML/org.neuroml.export)](https://github.com/NeuroML/org.neuroml.export/pulls)
[![GitHub issues](https://img.shields.io/github/issues/NeuroML/org.neuroml.export)](https://github.com/NeuroML/org.neuroml.export/issues)
Expand Down
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<groupId>org.neuroml.export</groupId>
<artifactId>org.neuroml.export</artifactId>
<packaging>bundle</packaging>
<version>1.8.1</version>
<version>1.9.1</version>
<name>org.neuroml.export</name>
<url>http://maven.apache.org</url>

Expand All @@ -18,12 +18,12 @@
<dependency>
<groupId>org.neuroml.model</groupId>
<artifactId>org.neuroml.model</artifactId>
<version>1.8.1</version>
<version>1.9.1</version>
</dependency>
<dependency>
<groupId>org.lemsml</groupId>
<artifactId>jlems</artifactId>
<version>0.10.6</version>
<version>0.10.8</version>
</dependency>
<dependency>
<groupId>org.apache.velocity</groupId>
Expand All @@ -49,7 +49,7 @@
&lt;br /&gt;
&lt;br /&gt;
</top>
<bottom>Copyright NeuroML Contributors 2021</bottom>
<bottom>Copyright NeuroML Contributors 2023</bottom>
</configuration>
</plugin>
<plugin>
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/org/lemsml/export/sedml/SEDMLWriter.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.neuroml.export.utils.support.ModelFeature;
import org.neuroml.model.util.NeuroMLException;
import org.neuroml.export.utils.support.SupportLevelInfo;
import org.neuroml.export.sbml.SBMLWriter;

public class SEDMLWriter extends AXMLWriter
{
Expand Down Expand Up @@ -274,24 +275,31 @@ public static void main(String[] args) throws Exception, ModelFeatureSupportExce
ArrayList<File> lemsFiles = new ArrayList<File>();


lemsFiles.add(new File("../neuroConstruct/osb/cerebral_cortex/networks/ACnet2/neuroConstruct/generatedNeuroML2/LEMS_TwoCell.xml"));
//lemsFiles.add(new File("../neuroConstruct/osb/cerebral_cortex/networks/ACnet2/neuroConstruct/generatedNeuroML2/LEMS_TwoCell.xml"));
//lemsFiles.add(new File("../OpenCortex/examples/LEMS_ACNet.xml"));

//lemsFiles.add(new File("../OpenCortex/examples/LEMS_SpikingNet.xml"));
//lemsFiles.add(new File("../OpenCortex/examples/LEMS_SimpleNet.xml"));
lemsFiles.add(new File("../neuroConstruct/osb/showcase/SBMLShowcase/NeuroML2/LEMS_NML2_Ex9_FN.xml"));
lemsFiles.add(new File("../neuroConstruct/osb/generic/HindmarshRose1984/NeuroML2/LEMS_Regular_HindmarshRose.xml"));


SEDMLWriter nw;
for(File lemsFile : lemsFiles)
{
Lems lems = Utils.readLemsNeuroMLFile(lemsFile.getAbsoluteFile()).getLems();
nw = new SEDMLWriter(lems, lemsFile.getParentFile(), lemsFile.getName().replaceAll(".xml", ".sedml"), lemsFile.getName(), Format.SBML);

SBMLWriter sbmlw = new SBMLWriter(lems, lemsFile.getParentFile(), lemsFile.getName().replaceAll(".xml", ".sbml"));
for(File genFile : sbmlw.convert())
{
System.out.println("Generated SBML: " + genFile.getAbsolutePath());
}

nw = new SEDMLWriter(lems, lemsFile.getParentFile(), lemsFile.getName().replaceAll(".xml", ".sedml"), lemsFile.getName(), Format.SBML);
List<File> ff = nw.convert();
for(File f : ff)
{
System.out.println("Generated sed-ml: " + f.getCanonicalPath());
System.out.println("Generated SED-ML: " + f.getCanonicalPath());
}

}
Expand Down
Loading
Loading