Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to region references/builders for HDMF 4.0 #1991

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 15, 2024

Motivation

HDMF 4.0 and hdmf-schema-language 3.0 are removing support for region references. There is an unused IO objectmapper class that refers to RegionBuilder, and a docs page that refers to RegionBuilder. This PR removes those.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from stephprince November 15, 2024 02:50
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (969c65f) to head (682cf71).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1991      +/-   ##
==========================================
+ Coverage   91.92%   92.04%   +0.12%     
==========================================
  Files          27       27              
  Lines        2713     2704       -9     
  Branches      708      705       -3     
==========================================
- Hits         2494     2489       -5     
+ Misses        145      141       -4     
  Partials       74       74              
Flag Coverage Δ
integration 72.92% <100.00%> (+0.05%) ⬆️
unit 82.98% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly merged commit d2fe84d into dev Nov 15, 2024
24 of 25 checks passed
@rly rly deleted the region branch November 15, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants