Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to region references/builders for HDMF 4.0 #1991

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Remove references to region references/builders for HDMF 4.0 #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16ac1f5
Remove references to region references/builders
rly Nov 15, 2024
682cf71
Update changelog
rly Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Enhancements and minor changes
* Added `NWBHDF5IO.read_nwb` convenience method to simplify reading an NWB file. @h-mayorquin [#1979](https://github.com/NeurodataWithoutBorders/pynwb/pull/1979)
* Removed unused references to region references and builders in preparation for changes in HDMF 4.0. @rly [#1991](https://github.com/NeurodataWithoutBorders/pynwb/pull/1991)

### Documentation and tutorial enhancements
- Added documentation example for `SpikeEventSeries`. @stephprince [#1983](https://github.com/NeurodataWithoutBorders/pynwb/pull/1983)
Expand Down
2 changes: 1 addition & 1 deletion docs/source/overview_software_architecture.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Builder
* :py:class:`~hdmf.build.builders.GroupBuilder` - represents a collection of objects
* :py:class:`~hdmf.build.builders.DatasetBuilder` - represents data
* :py:class:`~hdmf.build.builders.LinkBuilder` - represents soft-links
* :py:class:`~hdmf.build.builders.RegionBuilder` - represents a slice into data (Subclass of :py:class:`~hdmf.build.builders.DatasetBuilder`)
* :py:class:`~hdmf.build.builders.ReferenceBuilder` - represents a reference to another group or dataset

* **Main Module:** :py:mod:`hdmf.build.builders`

Expand Down
15 changes: 1 addition & 14 deletions src/pynwb/io/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from hdmf.build import ObjectMapper, RegionBuilder
from hdmf.build import ObjectMapper
from hdmf.common import VectorData
from hdmf.utils import getargs, docval
from hdmf.spec import AttributeSpec
Expand Down Expand Up @@ -40,19 +40,6 @@ def __init__(self, spec):
self.map_spec('description', spec.get_attribute('notes'))


class NWBTableRegionMap(NWBDataMap):

@ObjectMapper.constructor_arg('table')
def carg_table(self, builder, manager):
return manager.construct(builder.data.builder)

@ObjectMapper.constructor_arg('region')
def carg_region(self, builder, manager):
if not isinstance(builder.data, RegionBuilder):
raise ValueError("'builder' must be a RegionBuilder")
return builder.data.region


@register_map(VectorData)
class VectorDataMap(ObjectMapper):

Expand Down
Loading