Create (experimental) outputOf primop.
#8813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
4 tasks
roberth
reviewed
Aug 11, 2023
src/libexpr/primops.cc
Outdated
| will return a placeholder for the output of the output of `myDrv`, | ||
| interpreted as a derivation. | ||
|
|
||
| It may help to compare to the `->` operator in C, which can also by |
There was a problem hiding this comment.
Why not the . operator in Nix?
I guess some distance may help, but it's not so great to assume knowledge of C.
There was a problem hiding this comment.
I removed that and referenced ^ in the CLI syntax for derived paths, which is what it actually corresponds to.
I don't think . is so good because the field in some sense "already exists", attributes in the attribute set being strict and all. but talking about ^ side-steps that issue.
src/libexpr/primops.cc
Outdated
|
|
||
| For instance, `builtins.outputOf (builtins.outputOf myDrv "out) "out"` | ||
| will return a placeholder for the output of the output of `myDrv`, | ||
| interpreted as a derivation. |
There was a problem hiding this comment.
Might be helpful to show what the process is for building the placeholder?
ie myDrv produces a .drv, which then produces a .drv, which is then built to get the actual value for the placeholder.
There was a problem hiding this comment.
I expanded upon this, but I didn't really make this clear yet I don't think.
Ericson2314
force-pushed
the
outputOf
branch
2 times, most recently
from
e1c3f03
to
368d213
Compare
Ericson2314
changed the title
outputOf primop.outputOf primop.
Ericson2314
changed the title
outputOf primop.outputOf primop.
4 tasks
Ericson2314
commented
Aug 14, 2023
Ericson2314
commented
Aug 14, 2023
roberth
reviewed
Aug 14, 2023
Ericson2314
force-pushed
the
outputOf
branch
2 times, most recently
from
87c3451
to
ecd4e6f
Compare
This choice of variable name makes it more clear what is going on. Co-authored-by: Robert Hensing <[email protected]>
`EvalState::mkSingleDerivedPathString` previously contained its own inverse (printing, rather than parsing) in order to validate what was parsed. Now that is pulled out into its own separate function: `EvalState::coerceToSingleDerivedPath`. In additional that pulled out logic is deduplicated with `EvalState::mkOutputString` via `EvalState::mkOutputStringRaw`, which is itself deduplicated (and generalized) with `DownstreamPlaceholder::mkOutputStringRaw`. All these changes make the unit tests simpler. (We would ideally write more unit tests for `mkSingleDerivedPathString` `coerceToSingleDerivedPath` directly, but we cannot yet do that because the IO in reading the store path won't work when the dummy store cannot hold anything. Someday we'll have a proper in-memory store which will work for this.) Co-authored-by: Robert Hensing <[email protected]>
Ericson2314
force-pushed
the
outputOf
branch
2 times, most recently
from
1deeb74
to
11c9d8b
Compare
roberth
reviewed
Aug 14, 2023
roberth
reviewed
Aug 14, 2023
Ericson2314
force-pushed
the
outputOf
branch
2 times, most recently
from
7f24e8a
to
c089400
Compare
roberth
approved these changes
Aug 14, 2023
In the Nix language, given a drv path, we should be able to construct another string referencing to one of its output. We can do this today with `(import drvPath).output`, but this only works for derivations we already have. With dynamic derivations, however, that doesn't work well because the `drvPath` isn't yet built: importing it like would need to trigger IFD, when the whole point of this feature is to do "dynamic build graph" without IFD! Instead, what we want to do is create a placeholder value with the right string context to refer to the output of the as-yet unbuilt derivation. A new primop in the language, analogous to `builtins.placeholder` can be used to create one. This will achieve all the right properties. The placeholder machinery also will match out the `outPath` attribute for CA derivations works. In 60b7121 we added that type of placeholder, and the derived path and string holder changes necessary to support it. Then in the previous commit we cleaned up the code (inspiration finally hit me!) to deduplicate the code and expose exactly what we need. Now, we can wire up the primop trivally! Part of RFC 92: dynamic derivations (tracking issue NixOS#6316) Co-authored-by: Robert Hensing <[email protected]>
roberth
approved these changes
Aug 14, 2023
|
Jon - you rule, this sounds super useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the Nix language, given a drv path, we should be able to construct another string referencing to one of its output. We can do this today with
(import drvPath).output, but this only works for derivations we already have.With dynamic derivations, however, that doesn't work well because the
drvPathisn't yet built: importing it like would need to trigger IFD, when the whole point of this feature is to do "dynamic build graph" without IFD!Instead, what we want to do is create a placeholder value with the right string context to refer to the output of the as-yet unbuilt derivation. A new primop in the language, analogous to
builtins.placeholdercan be used to create one. This will achieve all the right properties. The placeholder machinery also will match out theoutPathattribute for CA derivations works.Context
Probably best to review these two commits separately!
In 60b7121 we added that type of placeholder, and the derived path and string holder changes necessary to support it. Then in first commit of this PR we cleaned up the code (inspiration finally hit me!) to deduplicate the code and expose exactly. what we need. In the second commit we can wire up the primop trivally!
Part of RFC 92: dynamic derivations (tracking issue #6316)
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.