Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dell precision 5490 #1173

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Add dell precision 5490 #1173

merged 3 commits into from
Oct 19, 2024

Conversation

teekuningas
Copy link
Contributor

Description of changes

Add minimal configuration for dell precision 5490.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Mic92 Mic92 changed the title Add 5490 Add dell precision 5490 Oct 12, 2024
# or even better: boot.kernelParams = pkgs.linuxPackages_latest;
boot.kernelParams = [ "i915.force_probe=7d55" ];

hardware.nvidia.open = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you instead include the gpu generation module in https://github.com/NixOS/nixos-hardware/tree/master/common/gpu/nvidia
This also allows us to make future fixes affecting the generation.

];

# or even better: boot.kernelParams = pkgs.linuxPackages_latest;
boot.kernelParams = [ "i915.force_probe=7d55" ];
Copy link
Member

@Mic92 Mic92 Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the text above, sounds like we want more something like:

Suggested change
boot.kernelParams = [ "i915.force_probe=7d55" ];
boot.kernelParams = lib.mkIf (lib.versionOlder config.boot.kernelPackages.kernel "6.6") [ "i915.force_probe=7d55" ];
boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "6.6") (lib.mkDefault pkgs.linuxPackages_latest);

Please replace 6.6 with the kernel version you think is the newest working one.

@teekuningas
Copy link
Contributor Author

How about now? Updated to import ada-lovelace config allowing removal of "hardware.nvidia.open"-line. Not sure if we want to force latest kernel but at least with force_probe=7d55 the graphical sessions boot even with an older kernel, and now its set only when necessary.

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Oct 19, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 99918df

mergify bot added a commit that referenced this pull request Oct 19, 2024
@mergify mergify bot merged commit 99918df into NixOS:master Oct 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants