-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dell precision 5490 #1173
Add dell precision 5490 #1173
Conversation
dell/precision/5490/default.nix
Outdated
# or even better: boot.kernelParams = pkgs.linuxPackages_latest; | ||
boot.kernelParams = [ "i915.force_probe=7d55" ]; | ||
|
||
hardware.nvidia.open = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you instead include the gpu generation module in https://github.com/NixOS/nixos-hardware/tree/master/common/gpu/nvidia
This also allows us to make future fixes affecting the generation.
dell/precision/5490/default.nix
Outdated
]; | ||
|
||
# or even better: boot.kernelParams = pkgs.linuxPackages_latest; | ||
boot.kernelParams = [ "i915.force_probe=7d55" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the text above, sounds like we want more something like:
boot.kernelParams = [ "i915.force_probe=7d55" ]; | |
boot.kernelParams = lib.mkIf (lib.versionOlder config.boot.kernelPackages.kernel "6.6") [ "i915.force_probe=7d55" ]; | |
boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "6.6") (lib.mkDefault pkgs.linuxPackages_latest); |
Please replace 6.6 with the kernel version you think is the newest working one.
How about now? Updated to import ada-lovelace config allowing removal of "hardware.nvidia.open"-line. Not sure if we want to force latest kernel but at least with force_probe=7d55 the graphical sessions boot even with an older kernel, and now its set only when necessary. |
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 99918df |
Description of changes
Add minimal configuration for dell precision 5490.
Things done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input