Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dell precision 5490 #1173

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Add dell precision 5490 #1173

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b5682f
Add basic dell precision 5490
teekuningas Oct 10, 2024
b5a932b
dell-precision-5490: fix tests and update README
teekuningas Oct 10, 2024
211d41b
dell-precision-5490: make force_probe conditional
teekuningas Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ See code for all available configurations.
| [Dell Optiplex 3050](dell/optiplex/3050) | `<nixos-hardware/dell/optiplex/3050>` |
| [Dell Poweredge R7515](dell/poweredge/r7515) | `<nixos-hardware/dell/poweredge/r7515>` |
| [Dell Precision 3541](dell/precision/3541) | `<nixos-hardware/dell/precision/3541>` |
| [Dell Precision 5490](dell/precision/5490) | `<nixos-hardware/dell/precision/5490>` |
| [Dell Precision 5530](dell/precision/5530) | `<nixos-hardware/dell/precision/5530>` |
| [Dell Precision 7520](dell/precision/7520) | `<nixos-hardware/dell/precision/7520>` |
| [Dell XPS 13 7390](dell/xps/13-7390) | `<nixos-hardware/dell/xps/13-7390>` |
Expand Down
15 changes: 15 additions & 0 deletions dell/precision/5490/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Dell Precision 5490

The internal monitor needs Linux Kernel >= 6.7 so enabling hybrid graphics does not work out of the box in 24.05. Setting

```
boot.kernelParams = [ "i915.force_probe=7d55" ];
```

helped but introduced some screen tearing.

Setting
```
boot.kernelPackages = pkgs.linuxPackages_latest;
```
in nixos-stable worked with no problems.
15 changes: 15 additions & 0 deletions dell/precision/5490/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{ lib, ... }:
{
imports = [
../../../common/gpu/nvidia
];

# or even better: boot.kernelParams = pkgs.linuxPackages_latest;
boot.kernelParams = [ "i915.force_probe=7d55" ];
Copy link
Member

@Mic92 Mic92 Oct 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the text above, sounds like we want more something like:

Suggested change
boot.kernelParams = [ "i915.force_probe=7d55" ];
boot.kernelParams = lib.mkIf (lib.versionOlder config.boot.kernelPackages.kernel "6.6") [ "i915.force_probe=7d55" ];
boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "6.6") (lib.mkDefault pkgs.linuxPackages_latest);

Please replace 6.6 with the kernel version you think is the newest working one.


hardware.nvidia.open = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you instead include the gpu generation module in https://github.com/NixOS/nixos-hardware/tree/master/common/gpu/nvidia
This also allows us to make future fixes affecting the generation.

hardware.nvidia.prime = {
intelBusId = "PCI:0:2:0";
nvidiaBusId = "PCI:1:0:0";
};
}
1 change: 1 addition & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
dell-optiplex-3050 = import ./dell/optiplex/3050;
dell-poweredge-r7515 = import ./dell/poweredge/r7515;
dell-precision-3541 = import ./dell/precision/3541;
dell-precision-5490 = import ./dell/precision/5490;
dell-precision-5530 = import ./dell/precision/5530;
dell-precision-5560 = import ./dell/precision/5560;
dell-precision-7520 = import ./dell/precision/7520;
Expand Down