Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: 0.10.0 -> 0.11.0 #143173

Merged
merged 1 commit into from
Oct 28, 2021
Merged

monitor: 0.10.0 -> 0.11.0 #143173

merged 1 commit into from
Oct 28, 2021

Conversation

bobby285271
Copy link
Member

Motivation for this change

https://github.com/stsdc/monitor/releases
https://github.com/stsdc/monitor/compare/0.10.0..0.11.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@@ -70,5 +77,6 @@ stdenv.mkDerivation rec {
maintainers = with maintainers; [ xiorcale ] ++ teams.pantheon.members;
platforms = platforms.linux;
license = licenses.gpl3;
mainProgram = "com.github.stsdc.monitor";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has the executable such a weird name?

Copy link
Member Author

@bobby285271 bobby285271 Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not weird, almost every package I maintains (monitor, notejot, khronos, taxi, torrential, ..., and all Pantheon packages) follows RDNN scheme for executable name. I guess I will consider creating alias only if elementary/default-settings#84 is accepted by elementary 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 you can find the binary easily in results and then bin

[nix-shell:~/.cache/nixpkgs-review/pr-143173]$ results/monitor/bin/com.github.stsdc.monitor

this ecosystem is not for terminal people

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ecosystem is not for terminal people

yeah, weird.

Copy link
Member

@davidak davidak Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird in the same way nix store paths are weird.

it solves a problem. you can install multiple applications with the same name, like Code

maybe there are more reasons. i haven't actually looked into it

https://medium.com/elementaryos/cleaning-up-app-codenames-ef9fc637ddef

This is encouraged by FreeDesktop.Org projects like D-BUS as well as by GNOME

@davidak
Copy link
Member

davidak commented Oct 28, 2021

Result of nixpkgs-review pr 143173 run on x86_64-linux 1

1 package built:
  • monitor

@davidak
Copy link
Member

davidak commented Oct 28, 2021

The program shows now also disks. Nice!

Screenshot from 2021-10-28 14-28-32

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

Builds, works

@davidak davidak merged commit b06c840 into NixOS:master Oct 28, 2021
@bobby285271 bobby285271 deleted the monitor branch October 28, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants