-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitor: 0.10.0 -> 0.11.0 #143173
monitor: 0.10.0 -> 0.11.0 #143173
Conversation
@@ -70,5 +77,6 @@ stdenv.mkDerivation rec { | |||
maintainers = with maintainers; [ xiorcale ] ++ teams.pantheon.members; | |||
platforms = platforms.linux; | |||
license = licenses.gpl3; | |||
mainProgram = "com.github.stsdc.monitor"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has the executable such a weird name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not weird, almost every package I maintains (monitor, notejot, khronos, taxi, torrential, ..., and all Pantheon packages) follows RDNN scheme for executable name. I guess I will consider creating alias only if elementary/default-settings#84 is accepted by elementary 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperSandro2000 you can find the binary easily in results
and then bin
[nix-shell:~/.cache/nixpkgs-review/pr-143173]$ results/monitor/bin/com.github.stsdc.monitor
this ecosystem is not for terminal people
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this ecosystem is not for terminal people
yeah, weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird in the same way nix store paths are weird.
it solves a problem. you can install multiple applications with the same name, like Code
maybe there are more reasons. i haven't actually looked into it
https://medium.com/elementaryos/cleaning-up-app-codenames-ef9fc637ddef
This is encouraged by FreeDesktop.Org projects like D-BUS as well as by GNOME
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Builds, works
Motivation for this change
https://github.com/stsdc/monitor/releases
https://github.com/stsdc/monitor/compare/0.10.0..0.11.0
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)