Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitor: 0.10.0 -> 0.11.0 #143173

Merged
merged 1 commit into from
Oct 28, 2021
Merged

monitor: 0.10.0 -> 0.11.0 #143173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions pkgs/applications/system/monitor/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{ lib, stdenv
{ lib
, stdenv
, fetchFromGitHub
, nix-update-script
, meson
Expand All @@ -13,18 +14,21 @@
, libwnck
, libgee
, libgtop
, libhandy
, sassc
, udisks2
, wrapGAppsHook
}:

stdenv.mkDerivation rec {
pname = "monitor";
version = "0.10.0";
version = "0.11.0";

src = fetchFromGitHub {
owner = "stsdc";
repo = "monitor";
rev = version;
sha256 = "sha256-Gin/1vbQbOAKFrjzDuDTNDQlTGTIlb0NUfIWWXd5tQ4=";
sha256 = "sha256-xWhhjn7zk/juXx50wLG2TpB5aqU+588kWBBquWrVJbM=";
fetchSubmodules = true;
};

Expand All @@ -45,7 +49,10 @@ stdenv.mkDerivation rec {
pantheon.wingpanel
libgee
libgtop
libhandy
libwnck
sassc
udisks2
];

postPatch = ''
Expand All @@ -70,5 +77,6 @@ stdenv.mkDerivation rec {
maintainers = with maintainers; [ xiorcale ] ++ teams.pantheon.members;
platforms = platforms.linux;
license = licenses.gpl3;
mainProgram = "com.github.stsdc.monitor";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has the executable such a weird name?

Copy link
Member Author

@bobby285271 bobby285271 Oct 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not weird, almost every package I maintains (monitor, notejot, khronos, taxi, torrential, ..., and all Pantheon packages) follows RDNN scheme for executable name. I guess I will consider creating alias only if elementary/default-settings#84 is accepted by elementary 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 you can find the binary easily in results and then bin

[nix-shell:~/.cache/nixpkgs-review/pr-143173]$ results/monitor/bin/com.github.stsdc.monitor

this ecosystem is not for terminal people

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ecosystem is not for terminal people

yeah, weird.

Copy link
Member

@davidak davidak Nov 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird in the same way nix store paths are weird.

it solves a problem. you can install multiple applications with the same name, like Code

maybe there are more reasons. i haven't actually looked into it

https://medium.com/elementaryos/cleaning-up-app-codenames-ef9fc637ddef

This is encouraged by FreeDesktop.Org projects like D-BUS as well as by GNOME

};
}