pypy{27,38,39}: refactor derivation #209675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 4 packages built:
|
|
Result of 1 package blacklisted:
4 packages built:
|
|
@ofborg build pypy27 pypy38 pypy39 |
wegank
reviewed
Jan 8, 2023
|
@ofborg build pypy27 pypy38 pypy39 |
|
Oops, doesn't work on aarch64-darwin. EDIT: But ofborg passes there. I tested on my machine against pypy27 and found that the aarch64-darwin part should be moved to preFixup = lib.optionalString (stdenv.isDarwin) ''
install_name_tool -change @rpath/lib${executable}-c.dylib $out/lib/lib${executable}-c.dylib $out/bin/${executable}
'' + lib.optionalString (stdenv.isDarwin && stdenv.isAarch64) ''
mkdir -p $out/${executable}-c/pypy/bin
mv $out/bin/${executable} $out/${executable}-c/pypy/bin/${executable}
ln -s $out/${executable}-c/pypy/bin/${executable} $out/bin/${executable}
''; |
|
LGTM. |
AndersonTorres
approved these changes
Jan 8, 2023
- Remove code related to i686 archs (not supported anymore since #209100) - Split non-install steps in installPhase in installCheckPhase/preFixup - Add missing pre/post hooks
This comment was marked as outdated.
This comment was marked as outdated.
|
Result of 4 packages built:
|
|
@ofborg build pypy27 pypy38 pypy39 |
wegank
approved these changes
Jan 8, 2023
There was a problem hiding this comment.
$ ls result/bin
pypy3 pypy3.9
$ result/bin/pypy3
Python 3.9.16 (feeb267ead3e6771d3f2f49b83e1894839f64fb7, Jan 08 2023, 19:32:57)
[PyPy 7.3.11 with GCC Clang 11.1.0] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>>
$ result/bin/pypy3.9
Python 3.9.16 (feeb267ead3e6771d3f2f49b83e1894839f64fb7, Jan 08 2023, 19:32:57)
[PyPy 7.3.11 with GCC Clang 11.1.0] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>>
|
Timeout in @ofborg build pypy27 pypy38 pypy39 |
|
Looks good on ofborg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
with lib;usage (Tracking issue: remove overuses ofwith lib;#208242)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes