Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixedit: init at 1.0.0 #348231

Closed
wants to merge 12 commits into from
Closed

nixedit: init at 1.0.0 #348231

wants to merge 12 commits into from

Conversation

fndov
Copy link

@fndov fndov commented Oct 13, 2024

A NixOS Multipurpose CLI/TUI Utility. https://github.com/fndov/nixedit

Features:

  • Full Terminal User Interface & Command line usage.
  • Search Configure Build Backup Update Delete Optimise in one step.
  • Complete Profile management, Integrated Creation & Removal.
  • Integrates with Github to upload backups of your configuration.

I'm sure there are no problems/bugs with the package, the last step was modifying default.nix. 👍

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 13, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 13, 2024
pkgs/tools/nix/nixedit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/nixedit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/nixedit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/nixedit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/nixedit/default.nix Outdated Show resolved Hide resolved
Copy link
Author

@fndov fndov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Author

@fndov fndov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, I'll look into this 👍

I tested the updated default.nix inside QEMU and used nixfmt before committing this. Hope this is everything left, let me know if there's anything I messed. The example links were helpful thanks 👍
pkgs/tools/nix/nixedit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/nixedit/default.nix Outdated Show resolved Hide resolved
@fndov
Copy link
Author

fndov commented Oct 14, 2024

I'm currently working on the stable branch, should be finished very soon.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move it under pkgs/by-name , also make sure this PR only contains only one commit.

@fndov
Copy link
Author

fndov commented Oct 16, 2024

I will create a new PR. With the pkgs/by-name change. And link it here.

@fndov fndov closed this Oct 16, 2024
@fndov fndov mentioned this pull request Oct 16, 2024
13 tasks
@fndov
Copy link
Author

fndov commented Oct 16, 2024

#349119 @drupol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants