nixedit: init at 1.0.0 #349119
Closed
nixedit: init at 1.0.0 #349119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
requested changes
Oct 16, 2024
drupol
requested changes
Oct 16, 2024
dotlambda
reviewed
Oct 16, 2024
pkgs/by-name/ni/nixedit/package.nix
Outdated
|
|
||
| meta = with lib; { | ||
| homepage = "https://github.com/fndov/nixedit"; | ||
| description = "A NixOS Multipurpose CLI/TUI Utility"; |
There was a problem hiding this comment.
Suggested change
| description = "A NixOS Multipurpose CLI/TUI Utility"; | |
| description = "NixOS Multipurpose CLI/TUI Utility"; |
https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#meta-attributes
pkgs/by-name/ni/nixedit/package.nix
Outdated
| $out/bin/nixedit --help > /dev/null | ||
| ''; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = { |
pkgs/by-name/ni/nixedit/package.nix
Outdated
| meta = with lib; { | ||
| homepage = "https://github.com/fndov/nixedit"; | ||
| description = "A NixOS Multipurpose CLI/TUI Utility"; | ||
| license = licenses.gpl3; |
pkgs/by-name/ni/nixedit/package.nix
Outdated
Comment on lines
58
to
61
| if ! uname -a | grep "NixOS" > /dev/null; then | ||
| echo "This package can only be installed on NixOS." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if ! uname -a | grep "NixOS" > /dev/null; then | |
| echo "This package can only be installed on NixOS." | |
| exit 1 | |
| fi |
It should be buildable anywhere though.
There was a problem hiding this comment.
my package interacts with NixOS and is not designed to run on any other distro or mac.
There was a problem hiding this comment.
But it can be built on a non-NixOS machine and then run on a NixOS one. Otherwise the build wouldn't be reproducible.
|
I have made a mistake, I will discard this PR and restart. I appreciate your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A NixOS Multipurpose CLI/TUI Utility. https://github.com/fndov/nixedit
Created new PR containing only one commit by request, closed: #348231
Merge ready.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.