neovim: improve lpeg patch for darwin #351423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
reviewed
Oct 26, 2024
GaetanLepage
force-pushed
the
neovim
branch
2 times, most recently
from
fe79a60
to
a984f61
Compare
|
|
|
question: with this amount of rebuilds, should this PR target staging? |
This is a good question. |
teto
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
it's not an urgent patch (the overlay for darwin can stay broken for ~2 weeks with no issue) so I would target staging (even if it's small derivations, the eval time is apparently an issue for hydra) if there was not the format commit (merging a reformat on staging will just create merge conflicts later).
Maybe ask on https://matrix.to/#/#staging:nixos.org what's the best. We are close to a release so I expect hydra to be loaded.
|
|
wegank
added
the
12.approvals: 2
Co-authored-by: Carlos Hernandez <[email protected]>
|
For reference, we took the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since this neovim commit, the current change we make to the
lpegderivation when building neovim on darwin has stopped working.We have noticed it in the neovim-nightly-overlay project.
This modification by @hurricanehrndz solves the issue and is the object of this PR.
Ping relevant people
neovim derivation maintainers: cc @manveru @rvolosatovs
co-maintainer of neovim-nightly-overlay: cc @willruggiano
Commits
neovim: remove uneffective substituteInPlace patchesThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.