fix(lpeg): Removing static build of lpeg #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fixes should be contributed and fixed back to nixpkg master.
What I don't understand is that this logic seems to be present on the upstream derivation of neovim. |
|
Not all, read closely
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Gaétan Lepage ***@***.***>
Sent: Friday, October 25, 2024 5:12:25 PM
To: nix-community/neovim-nightly-overlay ***@***.***>
Cc: Carlos Hernandez ***@***.***>; Author ***@***.***>
Subject: Re: [nix-community/neovim-nightly-overlay] fix(lpeg): Removing static build of lpeg (PR #683)
These fixes should be contributed and fixed back to nixpkg master.
What I don't understand is that this logic seems to be present on the upstream derivation of neovim.
—
Reply to this email directly, view it on GitHub<#683 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMJBTJHELTX73LFRPSEFGLZ5LF5TAVCNFSM6AAAAABQUFBMQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZGAZDQMRQGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
willruggiano
requested changes
Oct 25, 2024
Can this be done today or should we delay it until nvim 0.11 lands on master ? |
GaetanLepage
requested changes
Oct 26, 2024
13 tasks
Co-authored-by: Gaétan Lepage <[email protected]>
|
As this patch ended up being upstream, I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes should be contributed and fixed back to nixpkg master.