posting: init at 2.0.1 #352663
posting: init at 2.0.1 #352663
Conversation
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
the
8.has: maintainer-list (update)
jorikvanveen
force-pushed
the
init-posting
branch
from
743ec9e
to
e6d4382
Compare
ofborg
bot
added
8.has: package (new)
|
jorikvanveen
force-pushed
the
init-posting
branch
from
e6d4382
to
04a1654
Compare
|
Thanks for reviewing! |
pkgs/by-name/po/posting/package.nix
Outdated
| # We patch the pyproject.toml to allow a slightly outdated watchfiles dependency. | ||
| # The correct version is not in nixpkgs yet and overriding the version is not trivial. | ||
| # (i tried) | ||
| patches = [ ./allow-watchfiles-v22.patch ]; |
There was a problem hiding this comment.
Is it possible to patch all the other things lower as well, or would that fail?
There was a problem hiding this comment.
Most requirements could probably be patched to the current nixpkgs version. Is this preferred over making sure the standard pyproject.toml is satisfied?
There was a problem hiding this comment.
Its case by case to be completely honest. I think just due to the sheer amount of overriding youre doing (which is a maintenance hassle) itd be generally easier for you and others if it was compatible with nixpkgs as-is. Of course, if its not possible thats a different problem.
There was a problem hiding this comment.
From matrix: https://matrix.to/#/!kjdutkOsheZdjqYmqp%3Anixos.org/%241sPNgtk0FyKTPgCoj5JHYfRZe4ZJ5Fq6d-zsNhRKoYM
Since this is an app it should be fine to use overrides here, though instead use packageOverrides (idk how this works but I can take a look at it later if you want)
There was a problem hiding this comment.
Alright I've made the pyproject use the nixpkgs version for everything except pydantic-settings and textual. The former causes a crash when I use the nixpkgs version and the latter is explicitly pinned by the maintainer of posting so I assume it will cause breakages if I relax that.
pkgs/by-name/po/posting/package.nix
Outdated
| # Current nixpkgs version is too outdated | ||
| pydantic-settings = ( | ||
| py-pkgs.pydantic-settings.overrideAttrs (oldAttrs: rec { | ||
| version = "2.6.0"; | ||
| src = fetchFromGitHub { | ||
| owner = "pydantic"; | ||
| repo = "pydantic-settings"; | ||
| rev = "refs/tags/v${version}"; | ||
| hash = "sha256-gJThzYJg6OIkfmfi/4MVINsrvmg+Z+0xMhdlCj7Fn+w="; | ||
| }; | ||
| propagatedBuildInputs = [ | ||
| pydantic | ||
| py-pkgs.python-dotenv | ||
| ]; | ||
| }) | ||
| ); | ||
|
|
||
| # Current nixpkgs version is too outdated | ||
| httpx = ( | ||
| py-pkgs.httpx.overrideAttrs (oldAttrs: rec { | ||
| version = "0.27.2"; | ||
| src = fetchFromGitHub { | ||
| owner = "encode"; | ||
| repo = oldAttrs.pname; | ||
| rev = "refs/tags/${version}"; | ||
| hash = "sha256-N0ztVA/KMui9kKIovmOfNTwwrdvSimmNkSvvC+3gpck="; | ||
| }; | ||
| nativeBuildInputs = oldAttrs.nativeBuildInputs ++ [ py-pkgs.zstandard ]; | ||
| }) | ||
| ); | ||
|
|
||
| # Current nixpkgs version is too outdated | ||
| textual = ( | ||
| py-pkgs.textual.overrideAttrs (oldAttrs: rec { | ||
| version = "0.85.0"; | ||
| src = fetchFromGitHub { | ||
| owner = "Textualize"; | ||
| repo = "textual"; | ||
| rev = "refs/tags/v${version}"; | ||
| hash = "sha256-ROq/Pjq6XRgi9iqMlCzpLmgzJzLl21MI7148cOxHS3o="; | ||
| }; | ||
| }) | ||
| ); | ||
|
|
||
| # Current nixpkgs version is too outdated | ||
| pydantic = ( | ||
| py-pkgs.pydantic.overrideAttrs (oldAttrs: rec { | ||
| version = "2.9.2"; | ||
| src = fetchFromGitHub { | ||
| owner = "pydantic"; | ||
| repo = "pydantic"; | ||
| rev = "refs/tags/v${version}"; | ||
| hash = "sha256-Eb/9k9bNizRyGhjbW/LAE/2R0Ino4DIRDy5ZrQuzJ7o="; | ||
| }; | ||
| propagatedBuildInputs = [ | ||
| pydantic-core | ||
| py-pkgs.annotated-types | ||
| py-pkgs.jsonschema | ||
| ]; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Can these be updated? (honestly this is probably non-trivial so if it is you can disregard this comment)
jorikvanveen
force-pushed
the
init-posting
branch
from
04a1654
to
562529b
Compare
jorikvanveen
force-pushed
the
init-posting
branch
from
562529b
to
3acd82e
Compare
|
So apparently #325971 exists, that's embarrassing... It looks like it has gone somewhat stale though, should I close this? |
@taha-yassine are you still willing to complete your PR? If not, this PR is doing the same thing. |
I haven't had time to finish working on my PR since I opened it so I'm glad you got posting to work with Nix. I will close my PR in favor of this one. |
jorikvanveen
force-pushed
the
init-posting
branch
from
3acd82e
to
b671eba
Compare
github-actions
bot
added
6.topic: nixos
nix-owners
bot
requested review from
manveru,
mrcjkb,
PerchunPak,
RaitoBezarius,
rvolosatovs,
teto and
thoughtpolice
|
Intended to be this many commits? Looks like a lot of unrelated stuff. |
|
No, not intentional. It appears something has gone wrong when I tried to rebase this branch to the latest master Sorry for all the pings! |
jorikvanveen
force-pushed
the
init-posting
branch
from
b671eba
to
3acd82e
Compare
github-actions
bot
removed
6.topic: nixos
|
It looks like you accidentally mass-pinged a bunch of people, which are now subscribed and getting notifications for everything in this pull request. Unfortunately, they cannot be automatically unsubscribed from the issue (removing review request does not unsubscribe), therefore development cannot continue in this pull request anymore. Please create a new pull request, link back to this one and ping the people actually involved in here over there. For the next time, remember to set your PR to draft status before rebasing. In draft status, you can preview the list of maintainers that are about to be requested for review, which allows you to sidestep this issue. Setting your pull request to draft prior to rebasing is strongly recommended. This is not a bulletproof method, though, as OfBorg still does review requests even on draft PRs. |
SigmaSquadron
removed request for
thoughtpolice,
manveru,
RaitoBezarius,
teto,
khaneliman,
mrcjkb,
rvolosatovs,
GaetanLepage,
figsoda and
PerchunPak
This adds the posting HTTP client. It's like insomnia or postman but it's a TUI. It also adds me to the maintainer list.
https://github.com/darrenburns/posting
https://posting.sh/
Fixes #351936
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.