Posting: init at 1.10.0 #325971
Closed
Posting: init at 1.10.0 #325971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
8.has: maintainer-list (update)
ofborg
bot
added
8.has: package (new)
ocfox
suggested changes
Jul 10, 2024
pkgs/development/python-modules/textual-autocomplete/default.nix
Outdated
Show resolved
Hide resolved
natsukium
reviewed
Jul 12, 2024
pkgs/development/python-modules/textual-autocomplete/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/textual-autocomplete/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/textual-autocomplete/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/textual-autocomplete/default.nix
Outdated
Show resolved
Hide resolved
Aleksanaa
reviewed
Jul 12, 2024
|
(refer pr in packaging request) |
taha-yassine
force-pushed
the
posting
branch
2 times, most recently
from
9ecfa7a
to
16025c1
Compare
|
@natsukium this PR is ready. Can you take a look please? |
Sigmanificient
suggested changes
Aug 2, 2024
pkgs/development/python-modules/textual-autocomplete/default.nix
Outdated
Show resolved
Hide resolved
|
@Sigmanificient thanks for your feedback. I took into account your suggestions and noticed that tests were added upstream. I tried adding them here but couldn't make them pass. I would appreciate if someone could give it a look. Otherwise should we just disable them? (Nice seeing a fellow Rennais here, did all my studies in Rennes and only recently left :) ) |
|
Perhaps, |
|
Closed in favor of #352663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.