Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.marimo: 0.9.1 -> 0.9.14; fix #353022

Merged
merged 1 commit into from
Nov 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions pkgs/development/python-modules/marimo/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,17 @@
lib,
buildPythonPackage,
fetchPypi,
pythonOlder,
setuptools,

# build-system
hatchling,

# dependencies
click,
docutils,
itsdangerous,
jedi,
markdown,
narwhals,
packaging,
psutil,
pygments,
Expand All @@ -19,32 +23,33 @@
uvicorn,
websockets,
pyyaml,
pytestCheckHook,

# tests
versionCheckHook,
}:

buildPythonPackage rec {
pname = "marimo";
version = "0.9.1";
version = "0.9.14";
pyproject = true;

disabled = pythonOlder "3.8";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for his removal? Marimo does not officially suppr 3.8 anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been removing those lately as they are more annoying than useful.
People often forget to update them.
Also, we technically only support python 3.11 and 3.12. So, as long as the package is supported for those versions, we don't really need to bother.


# The github archive does not include the static assets
src = fetchPypi {
inherit pname version;
hash = "sha256-7sG6i1WusNuCpuaojFXhSfPWCA2/nzHXvMF29ApGTDg=";
hash = "sha256-Q3dnRuAS8B4cWvF04GGg5OOZtmAJPKa2fHwnoO2DXDs=";
};

build-system = [ setuptools ];
build-system = [ hatchling ];

# ruff is not packaged as a python module in nixpkgs
pythonRemoveDeps = [ "ruff" ];
pythonRelaxDeps = [ "websockets" ];

dependencies = [
click
docutils
itsdangerous
jedi
markdown
narwhals
packaging
psutil
pygments
Expand All @@ -57,17 +62,21 @@ buildPythonPackage rec {
pyyaml
];

nativeCheckInputs = [ pytestCheckHook ];

pythonImportsCheck = [ "marimo" ];

meta = with lib; {
# The pypi archive does not contain tests so we do not use `pytestCheckHook`
nativeCheckInputs = [
versionCheckHook
];
versionCheckProgramArg = [ "--version" ];

meta = {
description = "Reactive Python notebook that's reproducible, git-friendly, and deployable as scripts or apps";
homepage = "https://github.com/marimo-team/marimo";
changelog = "https://github.com/marimo-team/marimo/releases/tag/${version}";
license = licenses.asl20;
license = lib.licenses.asl20;
mainProgram = "marimo";
maintainers = with maintainers; [
maintainers = with lib.maintainers; [
akshayka
dmadisetti
];
Expand Down