Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.marimo: 0.9.1 -> 0.9.14; fix #353022

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 1, 2024

Things done

Changelog: https://github.com/marimo-team/marimo/releases/tag/0.9.14

cc @akshayka @dmadisetti

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage changed the title python312Packages.marimo: 0.9.1 -> 0.9.14 python312Packages.marimo: 0.9.1 -> 0.9.14; fix Nov 1, 2024
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353022


x86_64-linux

✅ 4 packages built:
  • marimo (python312Packages.marimo)
  • marimo.dist (python312Packages.marimo.dist)
  • python311Packages.marimo
  • python311Packages.marimo.dist

aarch64-linux

✅ 4 packages built:
  • marimo (python312Packages.marimo)
  • marimo.dist (python312Packages.marimo.dist)
  • python311Packages.marimo
  • python311Packages.marimo.dist

x86_64-darwin

✅ 4 packages built:
  • marimo (python312Packages.marimo)
  • marimo.dist (python312Packages.marimo.dist)
  • python311Packages.marimo
  • python311Packages.marimo.dist

aarch64-darwin

✅ 4 packages built:
  • marimo (python312Packages.marimo)
  • marimo.dist (python312Packages.marimo.dist)
  • python311Packages.marimo
  • python311Packages.marimo.dist

@GaetanLepage GaetanLepage mentioned this pull request Nov 1, 2024
13 tasks
Copy link
Contributor

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks redoing this! I was going pick it back up once narwhals got in

FE build is possible- but I think it will break auto update. I think this is OK for now, and if things get more complex I will get that changed in

pyproject = true;

disabled = pythonOlder "3.8";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for his removal? Marimo does not officially suppr 3.8 anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been removing those lately as they are more annoying than useful.
People often forget to update them.
Also, we technically only support python 3.11 and 3.12. So, as long as the package is supported for those versions, we don't really need to bother.

@natsukium natsukium added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 2, 2024
@ofborg ofborg bot requested review from dmadisetti and akshayka November 2, 2024 11:14
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 2, 2024
@GaetanLepage GaetanLepage merged commit 70c41d3 into NixOS:master Nov 2, 2024
31 of 32 checks passed
@GaetanLepage GaetanLepage deleted the marimo branch November 2, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants