-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sccmhunter: Init at 1.0.6-unstable-2024-10-30 #353121
base: master
Are you sure you want to change the base?
Conversation
Shortened output of
|
Tested build for
And package runs as expected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Nixpkgs! Some suggestions
pyasn1 | ||
pyasn1-modules | ||
requests | ||
requests-kerberos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add requests-kerberos
? I don't find it in dependencies upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, during my testing / building of the packages, it was a required package that was not listed within requirements.txt
.
But, it seems that this was only by mistake (garrettfoster13/sccmhunter#75) and the dependency has since then been removed (garrettfoster13/sccmhunter@4c6669e).
Should I bump the commit rev to a newer commit where requests-kerberos
is not included anymore?
Co-authored-by: Moraxyc <[email protected]>
Co-authored-by: Moraxyc <[email protected]>
Thank you very much for your helpful review! Much appreciated! 🙂 |
Hello!
I added
sccmhunter
(https://github.com/garrettfoster13/sccmhunter) and addedpurpole
to the maintainers list.sccmhunter
is a python post-exploitation tool that can be used by pentesters and administrators to identify, profile and attack SCCM related assets in an Active Directory environment.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.