Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sccmhunter: Init at 1.0.6-unstable-2024-10-30 #353121

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

purpole
Copy link

@purpole purpole commented Nov 2, 2024

Hello!

I added sccmhunter (https://github.com/garrettfoster13/sccmhunter) and added purpole to the maintainers list.

sccmhunter is a python post-exploitation tool that can be used by pentesters and administrators to identify, profile and attack SCCM related assets in an Active Directory environment.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 2, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 2, 2024
@purpole
Copy link
Author

purpole commented Nov 2, 2024

Shortened output of nix-shell -p nixpkgs-review --run "nixpkgs-review pr 353121":

--------- Impacted packages on 'x86_64-linux' ---------
1 package added:
sccmhunter (init at 1.0.6-unstable-2024-10-30)

...

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/353121

--------- Report for 'x86_64-linux' ---------
2 packages built:
sccmhunter sccmhunter.dist

@purpole
Copy link
Author

purpole commented Nov 2, 2024

Tested build for x86_64-linux:

[david@nixos]$ nix-build -A sccmhunter
/nix/store/yw4z8kqmjr3i0iynamdcrph1n10m0fnp-sccmhunter-1.0.6-unstable-2024-10-30

And package runs as expected:

[david@nixos]$ ./result/bin/sccmhunter.py --help
SCCMHunter v1.0.5 by @unsigned_sh0rt
                                                                                                         
 Usage: sccmhunter [OPTIONS] COMMAND [ARGS]...                                                           
                                                                                                         
╭─ Options ─────────────────────────────────────────────────────────────────────────────────────────────╮
│ --help  -h        Show this message and exit.                                                         │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─ Commands ────────────────────────────────────────────────────────────────────────────────────────────╮
│ admin   Run administrative commands through the AdminService API.                                     │
│ dpapi   Extract SCCM secrets from DPAPI encrypted blobs, requires Local Administrator privileges.     │
│ find    Enumerate LDAP for SCCM assets.                                                               │
│ http    Abuse client enrollment.                                                                      │
│ mssql   MSSQL relay abuse.                                                                            │
│ show    Show and/or recon table results.                                                              │
│ smb     Profile and Enumerate SMB shares of discovered SCCM servers.                                  │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────╯

Copy link
Contributor

@Moraxyc Moraxyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Nixpkgs! Some suggestions

pkgs/by-name/sc/sccmhunter/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sc/sccmhunter/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sc/sccmhunter/package.nix Show resolved Hide resolved
pkgs/by-name/sc/sccmhunter/package.nix Outdated Show resolved Hide resolved
pyasn1
pyasn1-modules
requests
requests-kerberos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, during my testing / building of the packages, it was a required package that was not listed within requirements.txt.

But, it seems that this was only by mistake (garrettfoster13/sccmhunter#75) and the dependency has since then been removed (garrettfoster13/sccmhunter@4c6669e).

Should I bump the commit rev to a newer commit where requests-kerberos is not included anymore?

pkgs/by-name/sc/sccmhunter/package.nix Outdated Show resolved Hide resolved
@purpole
Copy link
Author

purpole commented Nov 7, 2024

Welcome to Nixpkgs! Some suggestions

Thank you very much for your helpful review! Much appreciated! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants