Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sccmhunter: Init at 1.0.6-unstable-2024-10-30 #353121
base: master
Are you sure you want to change the base?
sccmhunter: Init at 1.0.6-unstable-2024-10-30 #353121
Changes from 2 commits
c964bed
9e5cec3
5c51cf4
feaa04e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add
requests-kerberos
? I don't find it in dependencies upstream.https://github.com/garrettfoster13/sccmhunter/blob/7f493d1499fec1a694d949d9de17f25acdb6a0a9/requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, during my testing / building of the packages, it was a required package that was not listed within
requirements.txt
.But, it seems that this was only by mistake (garrettfoster13/sccmhunter#75) and the dependency has since then been removed (garrettfoster13/sccmhunter@4c6669e).
Should I bump the commit rev to a newer commit where
requests-kerberos
is not included anymore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the using rev currently does not have it anymore. It's ok to just remove this dependency here.
https://github.com/garrettfoster13/sccmhunter/blob/7f493d1499fec1a694d949d9de17f25acdb6a0a9/lib/attacks/admin.py