-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move things around #404
Merged
Merged
Move things around #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming at fixing these TODOs from #402
compute_sd
,n_boot_samps
,max_batch_size
,min_n_batches
out of adaptive_arguments and into a new argument list calledextra_estimation_args
adaptive
toiterative
(better reflecting what is actually going on)adaptive_arguments
toiterative_args
keep_samp_for_vS
,MSEv_uniform_comb_weights
andsaving_path
into a new input arg calledoutput_args
shapley_reweighting
tokernelSHAP_reweighting
saving_path
and iterative_results to the main output to make it easier to access for usersconvergence_tolerance
->convergence_tol
Updated arguments of explain:
Updated output from explain()