Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapr version 1.0.0 #402

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Shapr version 1.0.0 #402

merged 13 commits into from
Oct 23, 2024

Conversation

martinju
Copy link
Member

@martinju martinju commented Oct 6, 2024

This should merge to master what eventually becomes shapr 1.0.0.
All changes up until that point should be made through separate PRs to be merge into the shapr_1.0.0 branch

Required in this PR

  • Add adaptive estimation
  • Add verbose
  • Get shaprpy to work again
  • Get explain_forecast to work again
  • Update explain_forecast to the new adaptive version
  • Add asymmetric/causal to explain

Other mandatory TODOs

  • Update the NEWS file

Minor TODOs (some might be skipped before release)

  • Consider moving compute_sd, n_boot_samps, max_batch_size, min_n_batches, saving_path out of adaptive_arguments and into a new argument list called something like additional_estimation_args Move things around #404
  • Consider renaming adaptive_arguments to adaptive_args Move things around #404
  • Consider moving keep_samp_for_vS and MSEv_uniform_comb_weights into a input arg called something like output_args Move things around #404
  • Consider renaming shapley_reweighting to kernelSHAP_reweighting Move things around #404
  • Consider moving saving_path and iter_res_dt to the main output to make it easier to access for users Move things around #404
  • add skip_on_os("mac)" for the vaeac tests which fails on mac due to differenences in torch seed (after Lars have verified the results locally on mac)

@martinju martinju mentioned this pull request Oct 6, 2024
16 tasks
…tion, verbose arguments ++ (#396)

Dealing with the leftovers in separate PRS into #402.
R/approach_timeseries.R Outdated Show resolved Hide resolved
R/compute_estimates.R Outdated Show resolved Hide resolved
R/documentation.R Outdated Show resolved Hide resolved
R/explain.R Outdated Show resolved Hide resolved
@martinju
Copy link
Member Author

martinju commented Oct 7, 2024

@aredelmeier Not sure if you consider yourself done with spell checks etc, but if you are going to do more, you can actually create a separate PR which is proposed merged into the shapr-1.0.0 branch (this one).
That's more efficient, and we can keep this PR a bit cleaner :-)

@martinju martinju mentioned this pull request Oct 7, 2024
7 tasks
LHBO pushed a commit to LHBO/shapr that referenced this pull request Oct 13, 2024
…tion, verbose arguments ++ (NorskRegnesentral#396)

Dealing with the leftovers in separate PRS into NorskRegnesentral#402.
@martinju martinju merged commit 4c7e223 into master Oct 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants