-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shapr version 1.0.0 #402
Merged
Merged
Shapr version 1.0.0 #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aredelmeier
reviewed
Oct 7, 2024
aredelmeier
reviewed
Oct 7, 2024
aredelmeier
reviewed
Oct 7, 2024
aredelmeier
reviewed
Oct 7, 2024
aredelmeier
reviewed
Oct 7, 2024
aredelmeier
reviewed
Oct 7, 2024
aredelmeier
reviewed
Oct 7, 2024
aredelmeier
reviewed
Oct 7, 2024
aredelmeier
reviewed
Oct 7, 2024
@aredelmeier Not sure if you consider yourself done with spell checks etc, but if you are going to do more, you can actually create a separate PR which is proposed merged into the shapr-1.0.0 branch (this one). |
10 tasks
LHBO
pushed a commit
to LHBO/shapr
that referenced
this pull request
Oct 13, 2024
…tion, verbose arguments ++ (NorskRegnesentral#396) Dealing with the leftovers in separate PRS into NorskRegnesentral#402.
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should merge to master what eventually becomes shapr 1.0.0.
All changes up until that point should be made through separate PRs to be merge into the shapr_1.0.0 branch
Required in this PR
Other mandatory TODOs
Minor TODOs (some might be skipped before release)
additional_estimation_args
Move things around #404adaptive_arguments
toadaptive_args
Move things around #404