[IMP] account*: Remove dependencies in demo data on tests #1391
Conversation
etobella
changed the title
etobella
force-pushed
the
17.0-fix-tests
branch
from
07975a0 to
294ad50
Compare
rvalyi
changed the title
etobella
force-pushed
the
17.0-fix-tests
branch
4 times, most recently
from
542f4e6 to
52fcfb6
Compare
etobella
force-pushed
the
17.0-fix-tests
branch
from
52fcfb6 to
c895718
Compare
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 59de9ab. Thanks a lot for contributing to OCA. ❤️ |
|
The PR title has nothing to do with the final content of the PR. The commits are not well explained. Why that change is performed in the logic? Please explain, or this should be reverted until justified. |
|
@pedrobaeza It is true, however, it was related to this commits
Originally, we added the commits to this branch. I don't know how, but weblate added the commits directly to 17.0 branch and it was failing. I noticed the issue today and I decided to fix the tests using the same PR in order to keep the history. Maybe it would have been better to add this information before in order to avoid this kind of confusion. |
|
Yeah, but asking the reasoning about what have been merged. It's not correctly explained in the commit message nor the PR. |
Right now, it depends a lot on demo data to execute tests. It is a good practice to remove all of these dependancies.
@victoralmau @rousseldenis @JordiBForgeFlow