Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] hr_holidays_public*: Use the context employee or the user's employee #130

Merged

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Jul 2, 2024

Use the context employee or the user's employee

Use case:

  • Go to Employees to an employee other than our own.
  • Go to the Time-off smart-buttons
  • We will have to see there the public holidays according to the employee's address

Please @pedrobaeza and @carolinafernandez-tecnativa can you review it?

@Tecnativa TT49839

…loyee

Use case:
- Go to Employees to an employee other than our own.
- Go to the Time-off smart-buttons
- We will have to see there the public holidays according to the employee's address

TT49839
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM, Thanks :)

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jul 2, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-130-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 93a52e4 into OCA:15.0 Jul 2, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6da361b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants