Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] hr_holidays_public_overtime #87

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Aug 14, 2023

This module adds support for public holidays in Odoo's overtime calculation.

Without this, public holidays are treated as normal work days from the PoV of overtime calculation.

Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member Author

hbrunn commented Aug 22, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @hbrunn you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@tv-openbig
Copy link

@hbrunn I can confirm it works. I have tested this in context of the following Pull request: OCA/hr-attendance#140

@hbrunn
Copy link
Member Author

hbrunn commented Sep 4, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @hbrunn you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@hbrunn hbrunn force-pushed the 15.0-hr_holidays_public_overtime branch from 9baf70e to d9beda3 Compare October 18, 2023 11:18
@hbrunn hbrunn force-pushed the 15.0-hr_holidays_public_overtime branch from d9beda3 to c2094b8 Compare October 18, 2023 11:24
@dreispt
Copy link
Member

dreispt commented Nov 18, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-87-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dcf6949 into OCA:15.0 Nov 18, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1922748. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants